tls: replace var with let and const - #30299
Closed
Nolikzero wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
addaleax
approved these changes
Nov 6, 2019
cjihrig
approved these changes
Nov 6, 2019
trivikr
reviewed
Nov 6, 2019
Comment thread
lib/_tls_common.js
| options.minVersion, options.maxVersion); | ||
| var i; | ||
| var val; | ||
| let i; |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
The variable i can be moved inside for loop on lines 107 and 123
for (let i = 0; i < ca.length; ++i) {for (let i = 0; i < cert.length; ++i) {
Sorry, something went wrong.
Comment thread
lib/_tls_common.js
| var i; | ||
| var val; | ||
| let i; | ||
| let val; |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
The variable val can be made const on lines 108 and 124
const val = ca[i];const val = cert[i];
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
pushed a commit
that referenced
this pull request
Nov 8, 2019
PR-URL: #30299 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Copy link
Copy Markdown
Member
|
Thanks for the contribution! 🎉 |
Sorry, something went wrong.
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2019
PR-URL: #30299 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
PR-URL: #30299 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30299 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist