FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix test-benchmark-cluster by Trott · Pull Request #30342 · nodejs/node · GitHub

/ node Public

test: fix test-benchmark-cluster - #30342

Merged
Trott merged 0 commit into
nodejs:masterfrom
Trott:fix-cluster-test
Nov 9, 2019
ConversationCommits (0)ChecksFiles changed
Merged

test: fix test-benchmark-cluster#30342
Trott merged 0 commit into
nodejs:masterfrom
Trott:fix-cluster-test

Conversation

Trott commented Nov 9, 2019

Copy link
Copy Markdown
Member

test-benchmark-cluster needs to account for an option added in 973f324.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 9, 2019

nodejs-github-bot commented Nov 9, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26495/

Trott commented Nov 9, 2019

Copy link
Copy Markdown
Member Author

This fixes the nightly node-daily-master CI job, so I'd like to fast-track it. 👍 if you're a Collaborator and you approve.

Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 9, 2019
Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 9, 2019

Trott commented Nov 9, 2019

Copy link
Copy Markdown
Member Author

Landed in acd35d9

Trott closed this Nov 9, 2019
Trott reopened this Nov 9, 2019
Trott merged commit acd35d9 into nodejs:master Nov 9, 2019
MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
test: fix test-benchmark-cluster
308f5e4 
test-benchmark-cluster needs to account for an option added in 973f324.

PR-URL: #30342
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR mentioned this pull request Nov 19, 2019
Merged
targos pushed a commit that referenced this pull request Dec 1, 2019
test: fix test-benchmark-cluster
4acd3c3 
test-benchmark-cluster needs to account for an option added in 973f324.

PR-URL: #30342
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
test: fix test-benchmark-cluster
5b42857 
test-benchmark-cluster needs to account for an option added in 973f324.

PR-URL: #30342
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs mentioned this pull request Dec 23, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
ZYSzys ZYSzys approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL