console: remove non-existant methods from docs - #30346
Closed
SimonSchick wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
SimonSchick
force-pushed
the
docs/remove-dead-inspector-methods
branch
from
22703ab to
1bceb10
Compare
November 10, 2019 07:10
lpinca
approved these changes
Nov 10, 2019
SimonSchick
force-pushed
the
docs/remove-dead-inspector-methods
branch
2 times, most recently
from
df39117 to
8d29657
Compare
November 10, 2019 07:58
Copy link
Copy Markdown
Contributor
Author
|
Fixed lint and commit message. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@SimonSchick I think doc: is more appropriate as subsystem in commit title. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Ah, I tried to use docs before but I guess it needs to be singular. |
Sorry, something went wrong.
SimonSchick
force-pushed
the
docs/remove-dead-inspector-methods
branch
from
8d29657 to
5e7d211
Compare
November 10, 2019 08:43
trivikr
approved these changes
Nov 10, 2019
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
danbev
pushed a commit
that referenced
this pull request
Nov 13, 2019
PR-URL: #30346 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2019
PR-URL: #30346 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
9 tasks
Merged
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
PR-URL: #30346 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30346 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
It seems these methods are not present anymore, not even with --inspect so I propose removing these docs.