FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v10.x] deps: V8: backport fb63e5cf55e9 by targos · Pull Request #30372 · nodejs/node · GitHub

/ node Public

[v10.x] deps: V8: backport fb63e5cf55e9 - #30372

Closed
targos wants to merge 1 commit into
nodejs:v10.x-stagingfrom
targos:fix-30369
Closed

[v10.x] deps: V8: backport fb63e5cf55e9#30372
targos wants to merge 1 commit into
nodejs:v10.x-stagingfrom
targos:fix-30369

Conversation

targos commented Nov 12, 2019

Copy link
Copy Markdown
Member

Original commit message:

[Intl] Fix output of hour:'2-digit', hour12: true

Bug: chromium:527926
Change-Id: I783ba59c6e4b117163e058032fb04283e1f43c46
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529260
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60379}

Refs: v8/v8@fb63e5c

Fixes: #30369

Original commit message:

    [Intl] Fix output of hour:'2-digit', hour12: true

    Bug: chromium:527926
    Change-Id: I783ba59c6e4b117163e058032fb04283e1f43c46
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529260
    Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
    Commit-Queue: Frank Tang <ftang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{nodejs#60379}

Refs: v8/v8@fb63e5c

Fixes: nodejs#30369
nodejs-github-bot added build Issues and PRs related to build files or the CI. v10.x v8 engine Issues and PRs related to the V8 dependency. labels Nov 12, 2019
targos changed the title deps: V8: backport fb63e5cf55e9 [v10.x] deps: V8: backport fb63e5cf55e9 Nov 12, 2019

This comment has been minimized.

Copy link
Copy Markdown
Member

V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/2624/

The centos7-ppcle failure is because #28458 isn't on 10.x-staging.

Copy link
Copy Markdown
Member

Landed #28458 on v10.x-staging
New V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2642

This comment has been minimized.

This comment has been minimized.

Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Dec 3, 2019
edited by BethGriggs
Loading

Copy link
Copy Markdown
Collaborator

BethGriggs pushed a commit that referenced this pull request Dec 3, 2019
Original commit message:

    [Intl] Fix output of hour:'2-digit', hour12: true

    Bug: chromium:527926
    Change-Id: I783ba59c6e4b117163e058032fb04283e1f43c46
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529260
    Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
    Commit-Queue: Frank Tang <ftang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60379}

Refs: v8/v8@fb63e5c

Fixes: #30369

Backport-PR-URL: #30372

Copy link
Copy Markdown
Member

Landed in 271b4137f0

BethGriggs closed this Dec 3, 2019
targos deleted the fix-30369 branch December 3, 2019 17:02
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
Original commit message:

    [Intl] Fix output of hour:'2-digit', hour12: true

    Bug: chromium:527926
    Change-Id: I783ba59c6e4b117163e058032fb04283e1f43c46
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529260
    Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
    Commit-Queue: Frank Tang <ftang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60379}

Refs: v8/v8@fb63e5c

Fixes: #30369

Backport-PR-URL: #30372
francois2metz added a commit to osmontrouge/osmontrouge that referenced this pull request Jan 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL