FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

benchmark: use let instead of var in assert by dnlup · Pull Request #30450 · nodejs/node · GitHub

/ node Public

benchmark: use let instead of var in assert - #30450

Closed
dnlup wants to merge 1 commit into
nodejs:masterfrom
dnlup:fix_benchmark_assert
ConversationCommits (1)ChecksFiles changed
Closed

benchmark: use let instead of var in assert#30450
dnlup wants to merge 1 commit into
nodejs:masterfrom
dnlup:fix_benchmark_assert

Conversation

dnlup commented Nov 12, 2019

Copy link
Copy Markdown
Contributor

Use let instead of var in benchmark/assert/deepequal-buffer.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added assert Issues and PRs related to the assert subsystem. benchmark Issues and PRs related to the benchmark subsystem. labels Nov 12, 2019
addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 12, 2019
dnlup force-pushed the fix_benchmark_assert branch from 585c821 to 350075c Compare November 12, 2019 18:56
dnlup mentioned this pull request Nov 12, 2019
Closed
2 tasks
dnlup changed the title benchmark: use let instead of var in assert [WIP] benchmark: use let instead of var in assert Nov 12, 2019
dnlup force-pushed the fix_benchmark_assert branch from 350075c to 294c7d6 Compare November 12, 2019 19:13
dnlup changed the title [WIP] benchmark: use let instead of var in assert benchmark: use let instead of var in assert Nov 12, 2019
trivikr approved these changes Nov 13, 2019
View reviewed changes

trivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, just some nits

Comment thread benchmark/assert/deepequal-map.js Outdated
Comment thread benchmark/assert/deepequal-set.js Outdated
Comment thread benchmark/assert/ok.js Outdated
Comment thread benchmark/assert/throws.js Outdated

SimonSchick commented Nov 13, 2019

Copy link
Copy Markdown
Contributor

Going slightly out of scope.
@trivikr if I was to submit a PR that changed all for(regular/in/of) loops to let/const respectively, would this be accepted?

dnlup force-pushed the fix_benchmark_assert branch from 294c7d6 to 769540a Compare November 13, 2019 16:22

trivikr commented Nov 13, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

if I was to submit a PR that changed all for(regular/in/of) loops to let/const respectively, would this be accepted?

@SimonSchick Short answer is most likely "No"

This is one of the Code and Learn tasks from workshop at NodeConfEU:

  • Label for other PRs code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events.
  • Conference schedule https://www.nodeconf.eu/schedule/
    • Workshop was conducted at 1400 hours UTC+00:00 on Monday, November 11, 2019

There are many other PRs which are doing var to let/const replacements in other files.
If you are interested, please wait for some time (say a month) for all those PRs to be merged, and then create your PR. Other options:

  • go through all open code-and-learn PRs to find out which files are not touched
  • ping NodeConfEU code-and-learn organizers @jasnell / @addaleax / @BridgeAR to find files which are yet to be updated.

I don't recommend doing it for all files at once it'l be difficult to review. For example, we still use var at some places for:

I think you can replace vs to let/const on module basis (one PR for http, one for fs etc) so that only the particular module team can review it.

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 13, 2019

nodejs-github-bot commented Nov 13, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26547/

nodejs-github-bot commented Nov 17, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26644/

gireeshpunathil pushed a commit that referenced this pull request Nov 17, 2019
benchmark: use let instead of var in assert
d1ce04c 
PR-URL: #30450
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

gireeshpunathil commented Nov 17, 2019

Copy link
Copy Markdown
Member

landed in d1ce04c , thanks for the contribution!

BridgeAR pushed a commit that referenced this pull request Nov 19, 2019
benchmark: use let instead of var in assert
0130d2b 
PR-URL: #30450
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR mentioned this pull request Nov 19, 2019
Merged
targos pushed a commit that referenced this pull request Dec 1, 2019
benchmark: use let instead of var in assert
7d113af 
PR-URL: #30450
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
benchmark: use let instead of var in assert
351ee64 
PR-URL: #30450
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs mentioned this pull request Dec 23, 2019
Merged
dnlup deleted the fix_benchmark_assert branch January 10, 2020 13:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
gireeshpunathil gireeshpunathil approved these changes
BridgeAR BridgeAR approved these changes
trivikr trivikr approved these changes
+1 more reviewer
devnexen devnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL