FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: remove unused sync result from ASYNC_CALL by skomski · Pull Request #3049 · nodejs/node · GitHub

/ node Public

src: remove unused sync result from ASYNC_CALL - #3049

Closed
skomski wants to merge 1 commit into
nodejs:masterfrom
skomski:fix-ufe-req-wrap
ConversationCommits (1)ChecksFiles changed
Closed

src: remove unused sync result from ASYNC_CALL#3049
skomski wants to merge 1 commit into
nodejs:masterfrom
skomski:fix-ufe-req-wrap

Conversation

skomski commented Sep 24, 2015

Copy link
Copy Markdown
Contributor

Fixes use-after-free of req_wrap if uv returns early err

mscdex added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Sep 24, 2015

bnoordhuis commented Sep 24, 2015

Copy link
Copy Markdown
Member

I'm 95% sure some APMs use the return value.

skomski force-pushed the fix-ufe-req-wrap branch 2 times, most recently from babbc51 to e3dc2f6 Compare September 26, 2015 20:38

skomski commented Sep 26, 2015

Copy link
Copy Markdown
Contributor Author

Updated to only fix the use-after-free without removing the unused sync result because APMs maybe use it.

bnoordhuis reviewed Sep 26, 2015
View reviewed changes
Comment thread src/node_file.cc

bnoordhuis Sep 26, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you set req_wrap = nullptr here?

Aside: the uv_req->path = nullptr is a memory leak waiting to happen. It's mostly benign now - I think.

skomski commented Oct 7, 2015

Copy link
Copy Markdown
Contributor Author

Merge?

bnoordhuis commented Oct 7, 2015

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/441/

skomski commented Oct 8, 2015

Copy link
Copy Markdown
Contributor Author

CI looks fine except of course stringbytes-external.

bnoordhuis pushed a commit to bnoordhuis/io.js that referenced this pull request Oct 8, 2015
src: fix u-a-free if uv returns err in ASYNC_CALL
ccaaae9 
PR-URL: nodejs#3049
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

bnoordhuis commented Oct 8, 2015

Copy link
Copy Markdown
Member

Thanks Karl, landed in ccaaae9.

bnoordhuis closed this Oct 8, 2015

jasnell commented Oct 9, 2015

Copy link
Copy Markdown
Member

@bnoordhuis ... should this land in v4.x before 4.2.0 lts is cut?

bnoordhuis commented Oct 9, 2015

Copy link
Copy Markdown
Member

It won't hurt. I've added the tag.

jasnell pushed a commit that referenced this pull request Oct 9, 2015
src: fix u-a-free if uv returns err in ASYNC_CALL
2314378 
PR-URL: #3049
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
jasnell mentioned this pull request Oct 10, 2015
Closed

MylesBorins commented Nov 17, 2015

Copy link
Copy Markdown
Contributor

landed in v4.x-staging as 2314378

This was referenced Sep 17, 2021
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 18, 2021
Open
Open
Open
Open
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL