doc: createRequire can take import.meta.url directly - #30495
Closed
GeoffreyBooth wants to merge 1 commit into
Closed
doc: createRequire can take import.meta.url directly#30495GeoffreyBooth wants to merge 1 commit into
GeoffreyBooth wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
MylesBorins
approved these changes
Nov 15, 2019
MylesBorins
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Can we please fast-track |
Sorry, something went wrong.
guybedford
approved these changes
Nov 15, 2019
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2019
PR-URL: #30495 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2019
PR-URL: #30495 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
PR-URL: #30495 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30495 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the createRequire example in https://nodejs.org/api/esm.html#esm_commonjs_json_and_native_modules to follow the new createRequire behavior, as opposed to the deprecated createRequireFromPath behavior. cc @MylesBorins
Checklist