util: never trigger proxy traps while inspecting objects by BridgeAR · Pull Request #30767 · nodejs/node · GitHub

Please have a look at the individual commits for details.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

This adds a couple of benchmarks to check different options and code paths.

This makes sure we do not retrieve the handler in case it's not required. This improves the performance a tiny bit for these cases.

CI: https://ci.nodejs.org/job/node-test-pull-request/27425/ ✅ (yellow build with a known Windows flake)

This adds a couple of benchmarks to check different options and code paths. PR-URL: #30767 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

This makes sure we do not retrieve the handler in case it's not required. This improves the performance a tiny bit for these cases. PR-URL: #30767 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

PR-URL: #30767 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Landed in 832290a...e11b909 🎉

This adds a couple of benchmarks to check different options and code paths. PR-URL: #30767 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

This makes sure we do not retrieve the handler in case it's not required. This improves the performance a tiny bit for these cases. PR-URL: #30767 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

PR-URL: #30767 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Depends on #30343 to land on v12.x-staging

This adds a couple of benchmarks to check different options and code paths. PR-URL: nodejs#30767 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

This makes sure we do not retrieve the handler in case it's not required. This improves the performance a tiny bit for these cases. PR-URL: nodejs#30767 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

PR-URL: nodejs#30767 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

This makes sure this function stays backwards compatible in case it's accessed through the binding directly. Refs: nodejs#29947 (comment) PR-URL: nodejs#30858 Refs: nodejs#30767 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>

This adds a couple of benchmarks to check different options and code paths. Backport-PR-URL: #31431 PR-URL: #30767 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

This makes sure we do not retrieve the handler in case it's not required. This improves the performance a tiny bit for these cases. Backport-PR-URL: #31431 PR-URL: #30767 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Backport-PR-URL: #31431 PR-URL: #30767 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

This makes sure this function stays backwards compatible in case it's accessed through the binding directly. Refs: #29947 (comment) Backport-PR-URL: #31431 PR-URL: #30858 Refs: #30767 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>

This adds a couple of benchmarks to check different options and code paths. Backport-PR-URL: #31431 PR-URL: #30767 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

This makes sure we do not retrieve the handler in case it's not required. This improves the performance a tiny bit for these cases. Backport-PR-URL: #31431 PR-URL: #30767 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Backport-PR-URL: #31431 PR-URL: #30767 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

This makes sure this function stays backwards compatible in case it's accessed through the binding directly. Refs: #29947 (comment) Backport-PR-URL: #31431 PR-URL: #30858 Refs: #30767 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>

BridgeAR added 3 commits December 2, 2019 18:28

benchmark: add more util inspect and format benchmarks

4e547f4

This adds a couple of benchmarks to check different options and code paths.

util: improve performance inspecting proxies

1effffd

This makes sure we do not retrieve the handler in case it's not required. This improves the performance a tiny bit for these cases.

util: never trigger any proxy traps using format()

fcf8b19

BridgeAR added util Issues and PRs related to the built-in util module. performance Issues and PRs related to the performance of Node.js. labels Dec 2, 2019

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Dec 2, 2019

This comment has been minimized.

Sign in to view

jasnell approved these changes Dec 2, 2019

View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 2, 2019

lundibundi approved these changes Dec 3, 2019

View reviewed changes

fixup: util: improve performance inspecting proxies

0f86ca4

This comment has been minimized.

Sign in to view

Trott approved these changes Dec 5, 2019

View reviewed changes

This comment has been minimized.

Sign in to view

BridgeAR added a commit that referenced this pull request Dec 6, 2019

util: never trigger any proxy traps using format()

e11b909

PR-URL: #30767 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

BridgeAR closed this Dec 6, 2019

BridgeAR mentioned this pull request Dec 8, 2019

src: accept single argument in getProxyDetails #30858

Closed

4 tasks

targos pushed a commit that referenced this pull request Dec 9, 2019

util: never trigger any proxy traps using format()

3898b23

PR-URL: #30767 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

targos added the backport-blocked-v12.x label Jan 14, 2020

BridgeAR deleted the inspect-prototype branch January 20, 2020 12:06

BridgeAR added backport-open-v12.x and removed backport-blocked-v12.x labels Jan 22, 2020

BridgeAR mentioned this pull request Jan 22, 2020

[v12.x] multiple util and assert backports #31431

Closed

4 tasks

MylesBorins added backported-to-v12.x and removed backport-open-v12.x labels Jan 30, 2020

targos mentioned this pull request Jan 30, 2020

v12.15.0 release proposal #31368

Closed

MylesBorins mentioned this pull request Feb 8, 2020

v12.16.0 proposal #31691

Merged

util: never trigger proxy traps while inspecting objects by BridgeAR · Pull Request #30767 · nodejs/node · GitHub

Uh oh!

Uh oh!

util: never trigger proxy traps while inspecting objects - #30767

util: never trigger proxy traps while inspecting objects#30767
BridgeAR wants to merge 4 commits into
nodejs:masterfrom
BridgeAR:inspect-prototype

BridgeAR commented Dec 2, 2019

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

nodejs-github-bot commented Dec 6, 2019 •
edited by BridgeAR
Loading

Uh oh!

Uh oh!

BridgeAR commented Dec 6, 2019

Uh oh!

targos commented Jan 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

util: never trigger proxy traps while inspecting objects by BridgeAR · Pull Request #30767 · nodejs/node · GitHub

Uh oh!

Uh oh!

util: never trigger proxy traps while inspecting objects - #30767

util: never trigger proxy traps while inspecting objects#30767BridgeAR wants to merge 4 commits intonodejs:masternodejs/node:masterfrom BridgeAR:inspect-prototypeBridgeAR/node:inspect-prototypeCopy head branch name to clipboard

Conversation

BridgeAR commented Dec 2, 2019

Checklist

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

nodejs-github-bot commented Dec 6, 2019 • edited by BridgeAR Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BridgeAR commented Dec 6, 2019

Uh oh!

targos commented Jan 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

util: never trigger proxy traps while inspecting objects#30767
BridgeAR wants to merge 4 commits into
nodejs:masterfrom
BridgeAR:inspect-prototype

nodejs-github-bot commented Dec 6, 2019 •
edited by BridgeAR
Loading