FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: improve doc writable streams: 'finish' event by dev-script · Pull Request #30889 · nodejs/node · GitHub

/ node Public

doc: improve doc writable streams: 'finish' event - #30889

Closed
dev-script wants to merge 1 commit into
nodejs:masterfrom
dev-script:doc/stream-finish-event
ConversationCommits (1)ChecksFiles changed
Closed

doc: improve doc writable streams: 'finish' event#30889
dev-script wants to merge 1 commit into
nodejs:masterfrom
dev-script:doc/stream-finish-event

Conversation

dev-script commented Dec 10, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

doc change for stream.md that 'finish' event should be before
writer.end

fixes: #30759

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

doc: improve doc writable streams: 'finish' event
eda7eb0 
doc change for stream.md that 'finish' event should be before
writer.end

fixes: #30759
nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Dec 10, 2019

dev-script commented Dec 10, 2019

Copy link
Copy Markdown
Contributor Author

@GrosSacASac please review.

ronag commented Dec 10, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

I'm not sure I understand the purpose here? 'finish' should be emitted in the next tick so the order there shouldn't matter. Is this to make it easier to understand?

GrosSacASac commented Dec 11, 2019

Copy link
Copy Markdown
Contributor

Yes to make it easier to understand and also to make it easier to switch to implementation that don't rely on this hidden gimmick.

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 13, 2019

Trott commented Dec 13, 2019

Copy link
Copy Markdown
Member

Landed in 08728a1

Trott closed this Dec 13, 2019
Trott pushed a commit that referenced this pull request Dec 13, 2019
doc: improve doc writable streams: 'finish' event
08728a1 
doc change for stream.md that 'finish' event should be before
writer.end

fixes: #30759

PR-URL: #30889
Fixes: #30759
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
doc: improve doc writable streams: 'finish' event
b53e2a8 
doc change for stream.md that 'finish' event should be before
writer.end

fixes: #30759

PR-URL: #30889
Fixes: #30759
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins mentioned this pull request Dec 17, 2019
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
doc: improve doc writable streams: 'finish' event
690deaa 
doc change for stream.md that 'finish' event should be before
writer.end

fixes: #30759

PR-URL: #30889
Fixes: #30759
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
doc: improve doc writable streams: 'finish' event
be4fffe 
doc change for stream.md that 'finish' event should be before
writer.end

fixes: #30759

PR-URL: #30889
Fixes: #30759
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins mentioned this pull request Feb 8, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation writable stream example confusing order

6 participants

Back | FazBrowse Home | New Git URL