FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

sys: Mark as deprecated by geek · Pull Request #309 · nodejs/node · GitHub

  1. nodejs
  2. node

Repository navigation

sys: Mark as deprecated - #309

Closed
geek wants to merge 4 commits into
nodejs:v1.xfrom
geek:v1.x
ConversationCommits (4)ChecksFiles changed
Closed

sys: Mark as deprecated#309
geek wants to merge 4 commits into
nodejs:v1.xfrom
geek:v1.x

Conversation

geek commented Jan 12, 2015

Copy link
Copy Markdown
Member

Replaces #182

geek mentioned this pull request Jan 12, 2015
Closed
cjihrig reviewed Jan 12, 2015
View reviewed changes
Comment thread lib/sys.js Outdated

cjihrig Jan 12, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Small nit, but could you change this to:

sys is deprecated. Use util instead. (Ref: #166 (comment))

cjihrig commented Jan 12, 2015

Copy link
Copy Markdown
Contributor

Other than one small comment, LGTM

cjihrig commented Jan 12, 2015

Copy link
Copy Markdown
Contributor

This falls into the same category as the fs.exists() deprecation in #257. Should this wait until after 1.0.0? cc: @piscisaureus

cjihrig commented Jan 12, 2015

Copy link
Copy Markdown
Contributor

@geek this fails make lint:

File does not end with new line. (setExports();)

geek commented Jan 12, 2015

Copy link
Copy Markdown
Member Author

@cjihrig fixed

rvagg commented Jan 12, 2015

Copy link
Copy Markdown
Member

I think this should land for 1.0.0, it was discussed and agreed at a TC meeting and was just waiting for the code. So lgtm.

rvagg commented Jan 12, 2015

Copy link
Copy Markdown
Member

@geek please squash the commits into the original one and we should be able to land this I think

geek commented Jan 13, 2015

Copy link
Copy Markdown
Member Author

Closing in favor of #317

geek closed this Jan 13, 2015

geek commented Jan 13, 2015

Copy link
Copy Markdown
Member Author

@rvagg fixed and ready in #317

geek deleted the v1.x branch January 13, 2015 00:43
rvagg mentioned this pull request Jan 13, 2015
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL