test: load common.js to test for global leaks - #3095
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
common.js contains code that checks for variables leaking into the global namespace. Load common.js in all tests that do not intentionally leak variables.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
It'd be cool if we could get a linter rule for this, that way reviewers can't miss it on new tests. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
+1 linter rule. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Also lgtm |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I've written an eslint rule for this and will submit it with a subsequent pull request. Thanks for the suggestion! |
Sorry, something went wrong.
Trott
added a commit
that referenced
this pull request
Oct 2, 2015
common.js contains code that checks for variables leaking into the global namespace. Load common.js in all tests that do not intentionally leak variables. PR-URL: #3095 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Trott
added a commit
that referenced
this pull request
Oct 2, 2015
common.js contains code that checks for variables leaking into the global namespace. Load common.js in all tests that do not intentionally leak variables. PR-URL: #3095 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
common.js contains code that checks for variables leaking into the
global namespace. Load common.js in all tests that do not
intentionally leak variables.