test: add coverage for vm: Module and SyntheticModule - #31028
Closed
andrewkuzmenko wants to merge 2 commits into
Closed
test: add coverage for vm: Module and SyntheticModule#31028andrewkuzmenko wants to merge 2 commits into
andrewkuzmenko wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
addaleax
approved these changes
Dec 19, 2019
devsnek
approved these changes
Dec 19, 2019
BridgeAR
approved these changes
Dec 19, 2019
devnexen
approved these changes
Dec 19, 2019
andrewkuzmenko
force-pushed
the
vm-module-basic-throws
branch
from
c7c3ff4 to
ec8dd28
Compare
December 19, 2019 20:31
lpinca
approved these changes
Dec 19, 2019
Comment thread
test/parallel/test-vm-module-basic.js
Outdated
andrewkuzmenko
force-pushed
the
vm-module-basic-throws
branch
from
ec8dd28 to
7e844e7
Compare
December 19, 2019 21:01
ZYSzys
approved these changes
Dec 20, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
added 2 commits
December 20, 2019 12:28
Test the impossibility of creating an abstract instance of the Module. Test of SyntheticModule to throw exception if invalid params in constructor
Fix 'max-len','no-restricted-syntax' (assert.throws must be envoken with at least two args) and useless blank lines at the end of file
andrewkuzmenko
force-pushed
the
vm-module-basic-throws
branch
from
7e844e7 to
d2ff9fa
Compare
December 20, 2019 10:01
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
approved these changes
Dec 20, 2019
Copy link
Copy Markdown
Member
|
Still LGTM @andrewkuzmenko thanks for rebasing so quickly after the conflict! Just as a note: we mostly care about the error code and roughly check that the error message is indeed about the correct property. I personally suggest to use assert.throws() in the future instead of common.expectsError(). It was originally used at times when assert was not as powerful and as callback variation. The only real difference is the magically type property that common.expectsError supports. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Landed in ee14a64. Thanks for the contribution! 🎉 |
Sorry, something went wrong.
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 22, 2019
Test the impossibility of creating an abstract instance of the Module. Test of SyntheticModule to throw exception if invalid params in constructor PR-URL: nodejs#31028 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Jan 3, 2020
Test the impossibility of creating an abstract instance of the Module. Test of SyntheticModule to throw exception if invalid params in constructor PR-URL: #31028 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
Test the impossibility of creating an abstract instance of the Module. Test of SyntheticModule to throw exception if invalid params in constructor PR-URL: #31028 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Test the impossibility of creating an abstract instance of the Module. Test of SyntheticModule to throw exception if invalid params in constructor PR-URL: #31028 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
code and learn task for additional coverage for situation when
creating an abstract instance of the Module and SyntheticModule throws exception if invalid params in constructor
Checklist