FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: fix Raspbian armv7 build by AHgPuK · Pull Request #31041 · nodejs/node · GitHub

/ node Public

tools: fix Raspbian armv7 build - #31041

Closed
AHgPuK wants to merge 1 commit into
nodejs:masterfrom
AHgPuK:master
ConversationCommits (1)ChecksFiles changed
Closed

tools: fix Raspbian armv7 build#31041
AHgPuK wants to merge 1 commit into
nodejs:masterfrom
AHgPuK:master

Conversation

AHgPuK commented Dec 20, 2019

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 20, 2019

nodejs-github-bot commented Dec 20, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27838/

nodejs-github-bot commented Dec 21, 2019 •
edited by Trott
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27846/ ✔️

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 21, 2019

Trott commented Dec 21, 2019

Copy link
Copy Markdown
Member

@nodejs/build @nodejs/build-files @nodejs/gyp @nodejs/platform-arm

rvagg commented Dec 22, 2019

Copy link
Copy Markdown
Member

@AHgPuK what version of Raspbian are you having trouble with and what hardware are you running? Can you give us some error output that demonstrates the need for this change? Our various ARM builds have not had a problem with this but we do a lot of cross compiling now so we could be missing something—it would be good to understand what that might be.

rvagg commented Dec 22, 2019

Copy link
Copy Markdown
Member

also compiler version would be nice too

AHgPuK commented Dec 22, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@rvagg
Error message I get: undefined reference to '__atomic_fetch_sub_8'
Raspbian version: Raspbian Buster with desktop
Raspbian build version: Linux pi4 4.19.88-v7l+ #1284 SMP Wed Dec 11 13:51:57 GMT 2019 armv7l
Hardware: Raspberry Pi 4 4Gb RAM
gcc (Raspbian 8.3.0-6+rpi1) 8.3.0

rvagg commented Dec 23, 2019

Copy link
Copy Markdown
Member

yeah, ok, we're neither testing Buster, nor GCC 8 yet, so I suppose there's something in this combination that we're not getting.

AHgPuK changed the title Fix Raspbian armv7 build tools: fix Raspbian armv7 build Dec 24, 2019
BridgeAR pushed a commit that referenced this pull request Dec 25, 2019
tools: fix Raspbian armv7 build
1bc7a50 
PR-URL: #31041
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

BridgeAR commented Dec 25, 2019

Copy link
Copy Markdown
Member

Landed in 1bc7a50 🎉

BridgeAR closed this Dec 25, 2019
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
tools: fix Raspbian armv7 build
048b7f4 
PR-URL: #31041
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR mentioned this pull request Jan 7, 2020
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
tools: fix Raspbian armv7 build
b714e94 
PR-URL: #31041
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
tools: fix Raspbian armv7 build
340ce92 
PR-URL: #31041
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Feb 8, 2020
Merged
richardlau mentioned this pull request Feb 4, 2021
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
addaleax addaleax approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL