FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

benchmark: include writev & callback in benchmark by ronag · Pull Request #31066 · nodejs/node · GitHub

/ node Public

benchmark: include writev & callback in benchmark - #31066

Closed
ronag wants to merge 5 commits into
nodejs:masterfrom
nxtedition:many-writes-writev
ConversationCommits (5)ChecksFiles changed
Closed

benchmark: include writev & callback in benchmark#31066
ronag wants to merge 5 commits into
nodejs:masterfrom
nxtedition:many-writes-writev

Conversation

ronag commented Dec 23, 2019

Copy link
Copy Markdown
Member

Currently we only consider write when benchmarking.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

benchmark: include writev in benchmark
d1603cd 
Currently we only consider write when benchmarking.
nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. stream Issues and PRs related to the stream subsystem. labels Dec 23, 2019
ronag changed the title benchmark: include writev in benchmark benchmark: include writev & callback in benchmark Dec 23, 2019
ronag force-pushed the many-writes-writev branch from 1f863ee to 4155712 Compare December 23, 2019 18:26
lundibundi approved these changes Dec 23, 2019
View reviewed changes
Comment thread benchmark/streams/writable-manywrites.js
Comment thread benchmark/streams/writable-manywrites.js Outdated
ronag mentioned this pull request Dec 23, 2019
Closed
4 tasks
BridgeAR requested changes Dec 24, 2019
View reviewed changes

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This actually requires the following test to be changed:

test/benchmark/test-benchmark-streams.js

ronag commented Dec 24, 2019

Copy link
Copy Markdown
Member Author

This actually requires the following test to be changed:

test/benchmark/test-benchmark-streams.js

Sorry, this is new for me. What is that and how does it need to be changed?

BridgeAR commented Dec 24, 2019

Copy link
Copy Markdown
Member

If you run the test with this addition, it will fail due to the added options that are not included in the test. It is a way to verify that at least one benchmark option passes for all benchmark files of the specific subsystem.

You could add something like writev: 'yes', callback: 'no'.

ronag requested a review from BridgeAR December 25, 2019 10:27
BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 25, 2019

BridgeAR commented Dec 25, 2019

Copy link
Copy Markdown
Member

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4115/

Marking as author ready. The benchmark test should be run while landing to verify that it works properly.

BridgeAR commented Dec 25, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Landed in f68285b 🎉

BridgeAR closed this Dec 25, 2019
BridgeAR pushed a commit that referenced this pull request Dec 25, 2019
benchmark: include writev in benchmark
f68285b 
Currently we only consider write when benchmarking.

PR-URL: #31066
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
benchmark: include writev in benchmark
01fd3be 
Currently we only consider write when benchmarking.

PR-URL: #31066
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR mentioned this pull request Jan 7, 2020
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
benchmark: include writev in benchmark
d5c0e4d 
Currently we only consider write when benchmarking.

PR-URL: #31066
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
benchmark: include writev in benchmark
471c59b 
Currently we only consider write when benchmarking.

PR-URL: #31066
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins mentioned this pull request Feb 8, 2020
Merged
snyk-bot mentioned this pull request Jun 1, 2021
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
BridgeAR BridgeAR approved these changes
+1 more reviewer
lundibundi lundibundi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL