FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: update parameters for chmod and chmodsync by santoshyadavdev · Pull Request #31085 · nodejs/node · GitHub

/ node Public

docs: update parameters for chmod and chmodsync - #31085

Closed
santoshyadavdev wants to merge 1 commit into
nodejs:masterfrom
santoshyadavdev:patch-1
ConversationCommits (1)ChecksFiles changed
Closed

docs: update parameters for chmod and chmodsync#31085
santoshyadavdev wants to merge 1 commit into
nodejs:masterfrom
santoshyadavdev:patch-1

Conversation

santoshyadavdev commented Dec 24, 2019

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Dec 24, 2019

gireeshpunathil commented Dec 25, 2019

Copy link
Copy Markdown
Member

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4114/

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 25, 2019

santoshyadavdev commented Dec 26, 2019

Copy link
Copy Markdown
Contributor Author

Thank you team, I have made the changes in commit message.

Trott commented Dec 27, 2019

Copy link
Copy Markdown
Member

@santoshyadav198613 Can you update the commit message to include a subsystem, a better description in the header, and punctuation in the body? If you just want to copy/paste, here's what I would recommend:

doc: update parameter type for fs.chmod()

The mode parameter of fs.chmod() and fs.chmodSync() can be a string or 
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

Trott removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 27, 2019
doc: update parameter type for fs.chmod()
c935580 
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

Trott commented Dec 27, 2019

Copy link
Copy Markdown
Member

doc: update parameter type for fs.chmod()

The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

Never mind. I made the edits myself and pushed it to the branch.

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 27, 2019

santoshyadavdev commented Dec 27, 2019

Copy link
Copy Markdown
Contributor Author

doc: update parameter type for fs.chmod()
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

Never mind. I made the edits myself and pushed it to the branch.

Sorry I also pushed the same changes.

Trott commented Dec 27, 2019

Copy link
Copy Markdown
Member

Sorry I also pushed the same changes.

Ha ha! Yeah, no problem. Thanks!

santoshyadavdev commented Dec 27, 2019

Copy link
Copy Markdown
Contributor Author

Sorry I also pushed the same changes.

Ha ha! Yeah, no problem. Thanks!

Thanks, this was my first PR sorry for the trouble.

Trott commented Dec 27, 2019

Copy link
Copy Markdown
Member

Landed in 283e7a4.

Thanks for the contribution! 🎉

Trott closed this Dec 27, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 27, 2019
doc: update parameter type for fs.chmod()
283e7a4 
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

PR-URL: nodejs#31085
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
cjihrig added a commit to cjihrig/node that referenced this pull request Dec 27, 2019
doc: update parameter type for fsPromises.chmod()
08064f3 
This was overlooked in nodejs#31085.
cjihrig mentioned this pull request Dec 27, 2019
Closed
3 tasks
Trott pushed a commit that referenced this pull request Dec 29, 2019
doc: update parameter type for fsPromises.chmod()
ba4d68c 
This was overlooked in #31085.

PR-URL: #31115
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
doc: update parameter type for fs.chmod()
4c29a6e 
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

PR-URL: #31085
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
doc: update parameter type for fsPromises.chmod()
6855788 
This was overlooked in #31085.

PR-URL: #31115
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR mentioned this pull request Jan 7, 2020
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
doc: update parameter type for fs.chmod()
671a5b7 
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

PR-URL: #31085
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Jan 14, 2020
doc: update parameter type for fsPromises.chmod()
54cbbae 
This was overlooked in #31085.

PR-URL: #31115
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
doc: update parameter type for fs.chmod()
a192afc 
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

PR-URL: #31085
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
doc: update parameter type for fsPromises.chmod()
13fe137 
This was overlooked in #31085.

PR-URL: #31115
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins mentioned this pull request Feb 8, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
gireeshpunathil gireeshpunathil approved these changes
trivikr trivikr approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL