FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: V8: bump v8_embedder_string for 0e21c1e637bf by ChALkeR · Pull Request #31096 · nodejs/node · GitHub

/ node Public

deps: V8: bump v8_embedder_string for 0e21c1e637bf - #31096

Closed
ChALkeR wants to merge 1 commit into
nodejs:masterfrom
ChALkeR:chalker/v8-cherrypick-scavenges-update-string
ConversationCommits (1)ChecksFiles changed
Closed

deps: V8: bump v8_embedder_string for 0e21c1e637bf#31096
ChALkeR wants to merge 1 commit into
nodejs:masterfrom
ChALkeR:chalker/v8-cherrypick-scavenges-update-string

Conversation

ChALkeR commented Dec 26, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

0e21c1e has landed without a proper v8_embedder_string bump, this is a follow-up fix.

Refs: 0e21c1e
Refs: #31007

The alternative would be to revert 0e21c1e (PR: #31098) and re-land #31007. Filing both to speed up things.

deps: V8: bump v8_embedder_string for 0e21c1e
4cf5402 
0e21c1e has landed without a proper
v8_embedder_string bump, this is a follow-up fix.

Refs: 0e21c1e
Refs: nodejs#31007
ChALkeR added the v8 engine Issues and PRs related to the V8 dependency. label Dec 26, 2019
ChALkeR requested a review from BridgeAR December 26, 2019 02:33
nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Dec 26, 2019
addaleax approved these changes Dec 26, 2019
View reviewed changes

addaleax left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This LGTM and I’d prefer this approach over a revert, but tbh, I’m good with just leaving this alone and doing nothing.

(Maybe to expand on that: The commit just before the landed on already bumps the embedder string. There isn’t any point in re-incrementing it, as far as I can tell.)

This was referenced Dec 26, 2019
Closed
Closed

BridgeAR commented Dec 27, 2019

Copy link
Copy Markdown
Member

@addaleax

There isn’t any point in re-incrementing it, as far as I can tell.

Shouldn't each individual backport commit bump the embedder string?

addaleax commented Dec 27, 2019

Copy link
Copy Markdown
Member

@BridgeAR Afaik, the only purpose of the embedder string is to identify a specific modified version of V8. If two V8 changes land right next to each other, why do we need to bump the string twice?

Trott commented Dec 28, 2019

Copy link
Copy Markdown
Member

Sounds like this has become unnecessary. I'm closing it, but of course feel free to re-open if you think I'm wrong to close it.

Trott closed this Dec 28, 2019
MylesBorins reopened this Dec 28, 2019
MylesBorins reviewed Dec 28, 2019
View reviewed changes

MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

MylesBorins commented Dec 28, 2019

Copy link
Copy Markdown
Contributor

For clarity I reopened this PR because I think simply bumping the embedder string is a better course of action than reverting and relanding the other PR

MylesBorins commented Dec 28, 2019

Copy link
Copy Markdown
Contributor

The revert being #31098

Trott commented Dec 28, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

For clarity I reopened this PR because I think simply bumping the embedder string is a better course of action than reverting and relanding the other PR

I closed it because I thought there was consensus on the third option: Do nothing because the string got bumped elsewhere in the meantime. (At least that was my interpretation of #31096 (review) and #31096 (comment) but maybe I'm misunderstanding something.)

MylesBorins commented Dec 28, 2019

Copy link
Copy Markdown
Contributor

We have generally bumped the string for every commit. Just because they came in the same PR doesn't mean they are treated as a single atomic change for the bump

At least that is how I've understood it to have been done up until this point.

We can choose to do nothing, but I think the bump in a separate commit is the correct action. Either of those are better than revert and reland imho

Trott approved these changes Dec 29, 2019
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm fine with the "do nothing" option too.

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 1, 2020
BridgeAR pushed a commit that referenced this pull request Jan 1, 2020
deps: V8: bump v8_embedder_string for 0e21c1e
9b0cbcf 
0e21c1e has landed without a proper
v8_embedder_string bump, this is a follow-up fix.

PR-URL: #31096
Refs: 0e21c1e
Refs: #31007
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

BridgeAR commented Jan 1, 2020

Copy link
Copy Markdown
Member

Landed in 9b0cbcf 🎉

I went ahead and landed it. That way it's consistent with the way we handled it so far.

BridgeAR closed this Jan 1, 2020
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
deps: V8: bump v8_embedder_string for 0e21c1e
e2ef1a9 
0e21c1e has landed without a proper
v8_embedder_string bump, this is a follow-up fix.

PR-URL: #31096
Refs: 0e21c1e
Refs: #31007
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR mentioned this pull request Jan 7, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
addaleax addaleax approved these changes
BridgeAR BridgeAR approved these changes
+1 more reviewer
MylesBorins MylesBorins left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL