benchmark: add benchmark on async_hooks enabled http server - #31100
Closed
legendecas wants to merge 3 commits into
Closed
benchmark: add benchmark on async_hooks enabled http server#31100legendecas wants to merge 3 commits into
legendecas wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Trott
requested changes
Dec 26, 2019
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This breaks test/benchmark/test-benchmark-async-hooks.js (which isn't run on every pull request but is run on nightly runs). You'll want to add the asyncHooks and c settings to that test. (Or add asyncHooks only and rename c to n in this benchmark.)
Feel free to dismiss this "request changes" review once the test is updated and passing.
Sorry, something went wrong.
legendecas
force-pushed
the
benchmark-async-hooks
branch
2 times, most recently
from
0795d79 to
e57bf76
Compare
January 1, 2020 09:13
Trott
reviewed
Jan 1, 2020
Comment thread
benchmark/async_hooks/http-server.js
Outdated
legendecas
force-pushed
the
benchmark-async-hooks
branch
from
e57bf76 to
500b240
Compare
January 1, 2020 14:22
BridgeAR
reviewed
Jan 1, 2020
Comment thread
benchmark/async_hooks/http-server.js
Comment thread
benchmark/async_hooks/http-server.js
Outdated
BridgeAR
approved these changes
Jan 1, 2020
Trott
reviewed
Jan 1, 2020
Comment thread
test/benchmark/test-benchmark-async-hooks.js
Outdated
Trott
approved these changes
Jan 1, 2020
jasnell
approved these changes
Jan 2, 2020
Copy link
Copy Markdown
Member
Author
|
Just updated the ordering according to @Trott 's suggestion. |
Sorry, something went wrong.
BridgeAR
pushed a commit
that referenced
this pull request
Jan 2, 2020
PR-URL: #31100 Refs: nodejs/diagnostics#124 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Jan 3, 2020
PR-URL: #31100 Refs: nodejs/diagnostics#124 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
PR-URL: #31100 Refs: nodejs/diagnostics#124 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #31100 Refs: nodejs/diagnostics#124 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/diagnostics#124
FWIW following is the result of the benchmark:
Checklist