FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: check inspector command Debugger.setInstrumentationBreakpoint by ulitink · Pull Request #31137 · nodejs/node · GitHub

/ node Public

test: check inspector command Debugger.setInstrumentationBreakpoint - #31137

Merged
aduh95 merged 6 commits into
nodejs:mainfrom
ulitink:inspector-instrumentation-breakpoint
May 12, 2024
ConversationCommits (6)ChecksFiles changed
Merged

test: check inspector command Debugger.setInstrumentationBreakpoint#31137
aduh95 merged 6 commits into
nodejs:mainfrom
ulitink:inspector-instrumentation-breakpoint

Conversation

ulitink commented Dec 30, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adds test case for inspector's method Debugger.setInstrumentationBreakpoint with beforeScriptExecution param.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 30, 2019
ulitink mentioned this pull request Dec 30, 2019
Open
addaleax added the inspector Issues and PRs related to the V8 inspector protocol label Dec 30, 2019

BridgeAR commented Jan 4, 2020

Copy link
Copy Markdown
Member

@ulitink is this ready to review? Or is this still work in progress?

ulitink commented Jan 5, 2020

Copy link
Copy Markdown
Contributor Author

@BridgeAR It is a test for an issue #31138. We can't merge this pull request until the issue is fixed because the test is broken. Sorry if such workflow is bad, we can simply reject the pull request and wait for the issue to be fixed, test is still referenced from it and can be found.

BridgeAR commented Jan 6, 2020

Copy link
Copy Markdown
Member

It is possible to add this test and mark it as failing in our status file. That way it would only fail in case this test passes. If I understood correct, this test is legit and it should pass while it fails at the moment. That way it's possible to just remove the test from our status file while fixing the issue.

Trott commented Jan 6, 2020

Copy link
Copy Markdown
Member

It is possible to add this test and mark it as failing in our status file. That way it would only fail in case this test passes. If I understood correct, this test is legit and it should pass while it fails at the moment. That way it's possible to just remove the test from our status file while fixing the issue.

If the test fails 100% of the time, probably best to put it in known_issues and then we can move it out to parallel (or wherever) when the fix is committed.

ulitink marked this pull request as ready for review January 11, 2020 03:05
BridgeAR approved these changes Jan 11, 2020
View reviewed changes

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

nodejs-github-bot commented Jan 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28379/

nodejs-github-bot commented Jan 12, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28406/

Trott commented Jan 14, 2020

Copy link
Copy Markdown
Member

@nodejs/inspector

BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72 Compare May 31, 2020 12:19
gireeshpunathil added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2020

gireeshpunathil commented Nov 5, 2020

Copy link
Copy Markdown
Member

Is this ready to land?

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2020

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Nov 8, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34211/

nodejs-github-bot commented Sep 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54029/

nodejs-github-bot commented Oct 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54580/

This was referenced Oct 7, 2023
Open
Open
Open
Open

nodejs-github-bot commented Oct 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54810/

nodejs-github-bot commented Nov 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55557/

larson-carter commented Apr 17, 2024

Copy link
Copy Markdown
Member

This is a quite old PR, I see it ties into #31138 is there any updates?

nodejs-github-bot commented May 3, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58895/

nodejs-github-bot commented May 10, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59079/

aduh95 reviewed May 11, 2024
View reviewed changes
Comment thread test/known_issues/test-inspector-instrumentation-breakpoint.js Outdated

aduh95 May 11, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It looks like skipping makes the test succeeds, which is considered a failure for known_issues/ tests..

nodejs-github-bot commented May 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59088/

nodejs-github-bot commented May 12, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59141/

nodejs-github-bot commented May 12, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59175/

nodejs-github-bot commented May 12, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59188/

aduh95 commented May 12, 2024

Copy link
Copy Markdown
Contributor

Landed in 291c121

targos mentioned this pull request May 13, 2024
Merged
marco-ippolito mentioned this pull request Jun 17, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
aduh95 aduh95 left review comments
jasnell jasnell approved these changes
BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL