FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: enhance use of Error from primordials by Sebastien-Ahkrin · Pull Request #31163 · nodejs/node · GitHub

/ node Public

lib: enhance use of Error from primordials - #31163

Closed
Sebastien-Ahkrin wants to merge 1 commit into
nodejs:masterfrom
Sebastien-Ahkrin:ErrorPrimordials
ConversationCommits (1)ChecksFiles changed
Closed

lib: enhance use of Error from primordials#31163
Sebastien-Ahkrin wants to merge 1 commit into
nodejs:masterfrom
Sebastien-Ahkrin:ErrorPrimordials

Conversation

Sebastien-Ahkrin commented Jan 2, 2020

Copy link
Copy Markdown
Contributor

Hello,
Now, in this PR I have added Error in the primordials eslint
so have created a line in "/lib/.eslintrc.yaml".

rules:
  no-restricted-globals:
  - name: Error
        message: "Use `const { Error } = primordials;` instead of the global."

And just import Error :).

const {
  // [...]
  Error,
} = primordials;

I hope this new PR will help you :x

nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Jan 2, 2020

Sebastien-Ahkrin commented Jan 2, 2020

Copy link
Copy Markdown
Contributor Author

Refs: #30697

BridgeAR commented Jan 2, 2020

Copy link
Copy Markdown
Member

Does this have any impact on instanceof checks?

targos commented Jan 2, 2020

Copy link
Copy Markdown
Member

Does this have any impact on instanceof checks?

No, the object is the same as the global one.

nodejs-github-bot commented Jan 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28122/

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 2, 2020

Sebastien-Ahkrin commented Jan 3, 2020

Copy link
Copy Markdown
Contributor Author

This PR is errored with the JS test suite in the "parallel/test-tick-processor-arguments" test ...
But i don't know why ...

i can reproduce the error now in my computer .
It's a "Unexpected end of JSON input" 😢

i will investigate 😄

https://travis-ci.com/nodejs/node/jobs/271895965

Sebastien-Ahkrin commented Jan 3, 2020

Copy link
Copy Markdown
Contributor Author

This PR is errored with the JS test suite in the "parallel/test-tick-processor-arguments" test ...
But i don't know why ...

i can reproduce the error now in my computer .
It's a "Unexpected end of JSON input" 😢

i will investigate 😄

https://travis-ci.com/nodejs/node/jobs/271895965

@targos found the error 😄 so its only because the file v8-prof-polyfill can't contain any primordials.
Si i have added this line:

/* eslint-disable no-restricted-globals */

I hope this will help you :)

nodejs-github-bot commented Jan 4, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28185/

nodejs-github-bot commented Jan 4, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28195/

Trott pushed a commit to Trott/io.js that referenced this pull request Jan 4, 2020
lib: replace use of Error with primordials
c9b93e2 
PR-URL: nodejs#31163
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Trott commented Jan 4, 2020

Copy link
Copy Markdown
Member

Landed in c9b93e2

Trott closed this Jan 4, 2020
targos pushed a commit that referenced this pull request Jan 6, 2020
lib: replace use of Error with primordials
f268621 
PR-URL: #31163
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR mentioned this pull request Jan 7, 2020
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
lib: replace use of Error with primordials
02ed713 
PR-URL: #31163
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
lib: replace use of Error with primordials
dc9a51d 
PR-URL: #31163
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins mentioned this pull request Feb 8, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
BridgeAR BridgeAR approved these changes
trivikr trivikr approved these changes
+1 more reviewer
devnexen devnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL