FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: add Int16Array primordials by Sebastien-Ahkrin · Pull Request #31205 · nodejs/node · GitHub

/ node Public

lib: add Int16Array primordials - #31205

Closed
Sebastien-Ahkrin wants to merge 1 commit into
nodejs:masterfrom
Sebastien-Ahkrin:Int16ArrayPrimordials
ConversationCommits (1)ChecksFiles changed
Closed

lib: add Int16Array primordials#31205
Sebastien-Ahkrin wants to merge 1 commit into
nodejs:masterfrom
Sebastien-Ahkrin:Int16ArrayPrimordials

Conversation

Sebastien-Ahkrin commented Jan 6, 2020

Copy link
Copy Markdown
Contributor

Hello,
For this PR I have added Int16Array in the primordials eslint
And i just have created a line in "/lib/.eslintrc.yaml".

rules:
  no-restricted-globals:
  - name: Int16Array 
      message: "Use `const { Int16Array } = primordials;` instead of the global."

And just add Int16Array .

const {
  // [...]
  Int16Array,
} = primordials;

I hope this new PR will help you :x

nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Jan 6, 2020

Sebastien-Ahkrin commented Jan 6, 2020

Copy link
Copy Markdown
Contributor Author

Refs: #30697

BridgeAR commented Jan 11, 2020

Copy link
Copy Markdown
Member

This needs a rebase.

mhdawson approved these changes Jan 14, 2020
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

antsmartian commented May 29, 2020

Copy link
Copy Markdown
Contributor

@Sebastien-Ahkrin Ping. This needs a rebase.

Sebastien-Ahkrin force-pushed the Int16ArrayPrimordials branch from 704d3ab to 28a624e Compare May 29, 2020 09:24

nodejs-github-bot commented May 29, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31622/

nodejs-github-bot commented May 31, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31670/

nodejs-github-bot commented May 31, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31674/

BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72 Compare May 31, 2020 12:19

nodejs-github-bot commented Jun 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31698/

targos pushed a commit that referenced this pull request Jun 2, 2020
lib: add Int16Array primordials
178efdf 
PR-URL: #31205
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

targos commented Jun 2, 2020

Copy link
Copy Markdown
Member

Landed in 178efdf. Thanks @Sebastien-Ahkrin

targos closed this Jun 2, 2020
This was referenced Jun 4, 2020
Closed
Open
Open
Open
Open
Open
codebytere pushed a commit that referenced this pull request Jun 18, 2020
lib: add Int16Array primordials
76123b9 
PR-URL: #31205
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
lib: add Int16Array primordials
54a2f3d 
PR-URL: #31205
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
codebytere pushed a commit that referenced this pull request Jul 9, 2020
lib: add Int16Array primordials
69291e4 
PR-URL: #31205
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
codebytere mentioned this pull request Jul 13, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
cjihrig cjihrig approved these changes
BridgeAR BridgeAR approved these changes
trivikr trivikr approved these changes
+2 more reviewers
targos targos approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL