FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Document readline keybindings by HarshithaKP · Pull Request #31256 · nodejs/node · GitHub

/ node Public

Document readline keybindings - #31256

Closed
HarshithaKP wants to merge 5 commits into
nodejs:masterfrom
HarshithaKP:readline_keybindings
ConversationCommits (5)ChecksFiles changed
Closed

Document readline keybindings#31256
HarshithaKP wants to merge 5 commits into
nodejs:masterfrom
HarshithaKP:readline_keybindings

Conversation

HarshithaKP commented Jan 8, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

This is a rework of closed pr #20825
fixes: #20814

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

doc: readline keybindings
96872ea 
Added readline keybindings table to document
doc: document readline keybindings
0de07fc 
This is a rework of closed pr nodejs#20825
fixes: nodejs#20814
nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 8, 2020

HarshithaKP commented Jan 8, 2020

Copy link
Copy Markdown
Member Author

cc: @shobhitchittora

antsmartian reviewed Jan 8, 2020
View reviewed changes
Comment thread doc/api/readline.md
antsmartian reviewed Jan 8, 2020
View reviewed changes
Comment thread doc/api/readline.md Outdated
BridgeAR reviewed Jan 8, 2020
View reviewed changes

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@HarshithaKP thank you very much for working on this!

Comment thread doc/api/readline.md
Comment thread doc/api/readline.md Outdated
Comment thread doc/api/readline.md Outdated
Comment thread doc/api/readline.md Outdated
Comment thread doc/api/readline.md Outdated
Comment thread doc/api/readline.md
Comment thread doc/api/readline.md Outdated
Comment thread doc/api/readline.md
Comment thread doc/api/readline.md Outdated
Comment thread doc/api/readline.md
BridgeAR reviewed Jan 8, 2020
View reviewed changes

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for following up so quickly! This almost looks good to me.

Comment thread doc/api/readline.md
Comment thread doc/api/readline.md
BridgeAR added the wip Issues and PRs that are still a work in progress. label Jan 9, 2020

shobhitchittora commented Jan 10, 2020

Copy link
Copy Markdown
Contributor

Thanks @HarshithaKP for picking this up.

HarshithaKP commented Jan 10, 2020

Copy link
Copy Markdown
Member Author

Ping @BridgeAR @antsmartian, I believe I addressed all the suggestions. Please have a look.

BridgeAR previously approved these changes Jan 10, 2020
View reviewed changes

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Just left some nits.

Comment thread doc/api/repl.md Outdated
Comment thread doc/api/repl.md Outdated
Comment thread doc/api/repl.md Outdated
BridgeAR removed the wip Issues and PRs that are still a work in progress. label Jan 10, 2020
BridgeAR dismissed their stale review January 10, 2020 15:03

The comments have to be addressed before this can land.

jasnell approved these changes Jan 12, 2020
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with @BridgeAR's suggestions applied.

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 13, 2020
BridgeAR pushed a commit that referenced this pull request Jan 13, 2020
doc: document readline key bindings
027eaac 
This documents all readline key bindings. It is a rework of
#20825

PR-URL: #31256
Fixes: #20814
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BridgeAR commented Jan 13, 2020

Copy link
Copy Markdown
Member

Landed in 027eaac 🎉

BridgeAR closed this Jan 13, 2020
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
doc: document readline key bindings
b9aca78 
This documents all readline key bindings. It is a rework of
#20825

PR-URL: #31256
Fixes: #20814
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere mentioned this pull request Jan 16, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
doc: document readline key bindings
c72fff6 
This documents all readline key bindings. It is a rework of
#20825

PR-URL: #31256
Fixes: #20814
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Mar 15, 2020
Closed
Closed

addaleax commented Mar 16, 2020

Copy link
Copy Markdown
Member

@codebytere Just fyi, this breaks make test for me on v12.x because there’s broken links in the documentation – I’ll still open backports for the other PRs as you suggested and try to make sure that tests pass as much as possible, but you may want to remove this commit from v12.x-staging

targos commented Apr 18, 2020

Copy link
Copy Markdown
Member

Let's wait for #31006 to land this one on v12.x

targos removed author ready PRs that have at least one approval, no outstanding review comments, and a CI started. backport-blocked-v12.x labels Apr 25, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
doc: document readline key bindings
cc9fa9f 
This documents all readline key bindings. It is a rework of
nodejs#20825

PR-URL: nodejs#31256
Fixes: nodejs#20814
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Apr 28, 2020
doc: document readline key bindings
1d2565b 
This documents all readline key bindings. It is a rework of
#20825

PR-URL: #31256
Fixes: #20814
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos mentioned this pull request May 2, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
BridgeAR BridgeAR approved these changes
+1 more reviewer
antsmartian antsmartian left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

doc: add doc for tty writes ( readline.js / REPL )

8 participants

Back | FazBrowse Home | New Git URL