FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: update ESLint to 7.0.0-alpha.2 by cjihrig · Pull Request #31400 · nodejs/node · GitHub

/ node Public

tools: update ESLint to 7.0.0-alpha.2 - #31400

Closed
cjihrig wants to merge 5 commits into
nodejs:masterfrom
cjihrig:eslint
ConversationCommits (5)ChecksFiles changed
Closed

tools: update ESLint to 7.0.0-alpha.2#31400
cjihrig wants to merge 5 commits into
nodejs:masterfrom
cjihrig:eslint

Conversation

cjihrig commented Jan 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Update ESLint to 7.0.0-alpha.2

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 17, 2020

Trott commented Jan 17, 2020

Copy link
Copy Markdown
Member

Is the idea that this won't land until 7.0.0 is out and the PR will be updated to include that?

cjihrig commented Jan 17, 2020

Copy link
Copy Markdown
Contributor Author

Is the idea that this won't land until 7.0.0 is out and the PR will be updated to include that?

I'm fine with that approach. FWIW, in the past, we have updated to ESLint alpha releases as well.

BridgeAR approved these changes Jan 20, 2020
View reviewed changes

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

Landing the updates incrementally allows us to adjust everything during the individual release and we could already use the changed features. The eslints changes are normally very stable, no matter that it's an alpha. I am fine with waiting or landing it right away therefore.

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 20, 2020
trivikr approved these changes Jan 20, 2020
View reviewed changes

trivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

cjihrig changed the title tools: update ESLint to 7.0.0-alpha.0 tools: update ESLint to 7.0.0-alpha.1 Feb 15, 2020
cjihrig changed the title tools: update ESLint to 7.0.0-alpha.1 tools: update ESLint to 7.0.0-alpha.2 Feb 28, 2020

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Mar 9, 2020 •
edited by cjihrig
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29667/ 💛

addaleax pushed a commit that referenced this pull request Mar 11, 2020
tools: update ESLint to 7.0.0-alpha.0
7eaa813 
Update ESLint to 7.0.0-alpha.0

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax pushed a commit that referenced this pull request Mar 11, 2020
tools: update ESLint to 7.0.0-alpha.1
2348ca0 
Update ESLint to 7.0.0-alpha.1

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

addaleax commented Mar 11, 2020

Copy link
Copy Markdown
Member

Landed in 61f28fb...4f87b4f

addaleax pushed a commit that referenced this pull request Mar 11, 2020
tools: update ESLint to 7.0.0-alpha.2
6712e4a 
Update ESLint to 7.0.0-alpha.2

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax pushed a commit that referenced this pull request Mar 11, 2020
tools: enable default-case-last lint rule
b4ca247 
PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax closed this Mar 11, 2020
addaleax pushed a commit that referenced this pull request Mar 11, 2020
tools: enable no-useless-backreference lint rule
4f87b4f 
PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
cjihrig deleted the eslint branch March 11, 2020 16:02
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
tools: update ESLint to 7.0.0-alpha.0
c70cfd2 
Update ESLint to 7.0.0-alpha.0

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
tools: update ESLint to 7.0.0-alpha.1
cac1d01 
Update ESLint to 7.0.0-alpha.1

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
tools: update ESLint to 7.0.0-alpha.2
814bb4a 
Update ESLint to 7.0.0-alpha.2

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
tools: enable default-case-last lint rule
d3c4210 
PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
tools: enable no-useless-backreference lint rule
35d0569 
PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins mentioned this pull request Mar 12, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
tools: update ESLint to 7.0.0-alpha.0
394fa1f 
Update ESLint to 7.0.0-alpha.0

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
tools: update ESLint to 7.0.0-alpha.1
e641b3c 
Update ESLint to 7.0.0-alpha.1

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
tools: update ESLint to 7.0.0-alpha.2
5dacfa7 
Update ESLint to 7.0.0-alpha.2

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
tools: enable default-case-last lint rule
bcf152e 
PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
tools: enable no-useless-backreference lint rule
ecf842e 
PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request Apr 22, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
BridgeAR BridgeAR approved these changes
trivikr trivikr approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL