fs: change streams to always emit close by default - #31408
Closed
ronag wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ronag
force-pushed
the
fs-stream-emit-close
branch
from
8d236d7 to
009687a
Compare
January 18, 2020 13:59
Copy link
Copy Markdown
Member
Author
|
@Trott: semver-major, also a CITGM please |
Sorry, something went wrong.
addaleax
approved these changes
Jan 18, 2020
Copy link
Copy Markdown
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/28475/ |
Sorry, something went wrong.
lpinca
approved these changes
Jan 19, 2020
BridgeAR
approved these changes
Jan 20, 2020
Previously due to compat reasons 'close' was only emitted if no 'error'. This removes the compat behavior in order to properly follow expected streams behavior.
Copy link
Copy Markdown
Member
Author
|
rebased to fix conflict |
Sorry, something went wrong.
ronag
force-pushed
the
fs-stream-emit-close
branch
from
009687a to
c3a49d7
Compare
January 20, 2020 12:58
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
approved these changes
Jan 20, 2020
Copy link
Copy Markdown
Member
|
Is the compat behavior documented anywhere that will need to be updated? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@Trott: I don't think so: Event: 'close'# Added in: v0.1.93 Emitted when the WriteStream's underlying file descriptor has been closed. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
pushed a commit
that referenced
this pull request
Jan 21, 2020
Previously due to compat reasons 'close' was only emitted if no 'error'. This removes the compat behavior in order to properly follow expected streams behavior. PR-URL: #31408 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
4 tasks
Trott
pushed a commit
to kevinoid/node
that referenced
this pull request
Jan 2, 2021
The default for the `emitClose` option was changed from `false` to `true` by nodejs#31408 which landed in f0d2df4 for v14.0.0. This commit updates the fs doc to match the current behavior. Signed-off-by: Kevin Locke <kevin@kevinlocke.name> PR-URL: nodejs#36653 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
The default for the `emitClose` option was changed from `false` to `true` by #31408 which landed in f0d2df4 for v14.0.0. This commit updates the fs doc to match the current behavior. Signed-off-by: Kevin Locke <kevin@kevinlocke.name> PR-URL: #36653 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
targos
pushed a commit
that referenced
this pull request
Aug 8, 2021
The default for the `emitClose` option was changed from `false` to `true` by #31408 which landed in f0d2df4 for v14.0.0. This commit updates the fs doc to match the current behavior. Signed-off-by: Kevin Locke <kevin@kevinlocke.name> PR-URL: #36653 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
BethGriggs
pushed a commit
that referenced
this pull request
Aug 12, 2021
The default for the `emitClose` option was changed from `false` to `true` by #31408 which landed in f0d2df4 for v14.0.0. This commit updates the fs doc to match the current behavior. Signed-off-by: Kevin Locke <kevin@kevinlocke.name> PR-URL: #36653 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously due to compat reasons 'close' was only emitted if no 'error'.
This removes the compat behavior in order to properly follow expected
streams behavior.
Not sure why this compat behavior has remained for so long but I believe it should be possible to make fs stream consistent with normal streams in a semver-major.
Checklist