FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: guide - using valgrind to debug memory leaks by mhdawson · Pull Request #31501 · nodejs/node · GitHub

/ node Public

doc: guide - using valgrind to debug memory leaks - #31501

Closed
mhdawson wants to merge 73 commits into
nodejs:masterfrom
mhdawson:valgrind
ConversationCommits (73)ChecksFiles changed
Closed

doc: guide - using valgrind to debug memory leaks#31501
mhdawson wants to merge 73 commits into
nodejs:masterfrom
mhdawson:valgrind

Conversation

mhdawson commented Jan 24, 2020

Copy link
Copy Markdown
Member

Add doc for using valgrind to debug native
memory leaks.

Started writing this up as part of an effort
in the Diagnostic WG but think it's better
to have it in the core guides and then be referenced
by the docs in the Diagnostic WG repo.

For more details on the Diagnostic WG effort see
nodejs/diagnostics#254 (comment)
This guide is related to /step3 - using_native_tools.md

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

doc: guide - using valgrind to debug memory leaks
12d0fe0 
Add doc for using valgrind to debug native
memory leaks.

Started writing this up as part of an effort
in the Diagnostic WG but think it's better
to have it in the core guides and then be referenced
by the docs in the Diagnostic WG repo.

For more details on the Diagnostic WG effort see
nodejs/diagnostics#254 (comment)
This guide is related to `/step3 - using_native_tools.md`
nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 24, 2020
mhdawson mentioned this pull request Jan 24, 2020
Closed

mhdawson commented Jan 24, 2020

Copy link
Copy Markdown
Member Author

@gireeshpunathil, @pmarton FYI

mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mscdex reviewed Jan 24, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated

mhdawson commented Jan 27, 2020

Copy link
Copy Markdown
Member Author

@mscdex, @addaleax. @Trott, @cjihrig, @gireeshpunathil thanks for the review and all the suggestions. Updated to incorporate them.

XhmikosR reviewed Jan 29, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
A Node.js process may run out of memory due to excessive consumption of
native memory. Native Memory is memory which is not managed by the
V8 Garbage collector and is allocated either by the Node.js runtime, its
dependencies or native [addons](://nodejs.org/docs/latest/api/n-api.html).

XhmikosR Jan 29, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is this link right? It's missing the protocol

mhdawson Jan 30, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for catching that

mhdawson Jan 30, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@XhmikosR fixed

lundibundi reviewed Jan 31, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
Comment thread doc/guides/investigating_native_memory_leak.md
mhdawson and others added 5 commits January 31, 2020 16:37
Update doc/guides/investigating_native_memory_leak.md
aeb5b93 
Co-Authored-By: Denys Otrishko <9109612+lundibundi@users.noreply.github.com>
Update doc/guides/investigating_native_memory_leak.md
70b9c40 
Co-Authored-By: Denys Otrishko <9109612+lundibundi@users.noreply.github.com>
Update doc/guides/investigating_native_memory_leak.md
eafd428 
Co-Authored-By: Denys Otrishko <9109612+lundibundi@users.noreply.github.com>
Update doc/guides/investigating_native_memory_leak.md
089d906 
Co-Authored-By: Denys Otrishko <9109612+lundibundi@users.noreply.github.com>
squash: address comments
b546680

mhdawson commented Jan 31, 2020

Copy link
Copy Markdown
Member Author

@mscdex, @addaleax. @Trott, @cjihrig any change you could take another look and approve if it looks ok?

lundibundi approved these changes Feb 1, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
Update doc/guides/investigating_native_memory_leak.md
7f8ddeb 
Co-Authored-By: Denys Otrishko <shishugi@gmail.com>
jasnell reviewed Feb 12, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
dependencies or native [addons](https://nodejs.org/docs/latest/api/n-api.html).

This guide provides information on how to use valgrind to investigate these
issues.

jasnell Feb 12, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

May be worthwhile stressing the point that this is Linux only

mhdawson commented Feb 14, 2020
View reviewed changes
Comment thread doc/guides/investigating_native_memory_leak.md Outdated
mhdawson added a commit that referenced this pull request Feb 14, 2020
doc: guide - using valgrind to debug memory leaks
79296dc 
Add doc for using valgrind to debug native
memory leaks.

Started writing this up as part of an effort
in the Diagnostic WG but think it's better
to have it in the core guides and then be referenced
by the docs in the Diagnostic WG repo.

For more details on the Diagnostic WG effort see
nodejs/diagnostics#254 (comment)
This guide is related to `/step3 - using_native_tools.md`

PR-URL: #31501
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

mhdawson commented Feb 14, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Landed in 89c1aa3

mhdawson closed this Feb 14, 2020
codebytere pushed a commit that referenced this pull request Feb 27, 2020
doc: guide - using valgrind to debug memory leaks
db291aa 
Add doc for using valgrind to debug native
memory leaks.

Started writing this up as part of an effort
in the Diagnostic WG but think it's better
to have it in the core guides and then be referenced
by the docs in the Diagnostic WG repo.

For more details on the Diagnostic WG effort see
nodejs/diagnostics#254 (comment)
This guide is related to `/step3 - using_native_tools.md`

PR-URL: #31501
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere mentioned this pull request Feb 29, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
doc: guide - using valgrind to debug memory leaks
df2355f 
Add doc for using valgrind to debug native
memory leaks.

Started writing this up as part of an effort
in the Diagnostic WG but think it's better
to have it in the core guides and then be referenced
by the docs in the Diagnostic WG repo.

For more details on the Diagnostic WG effort see
nodejs/diagnostics#254 (comment)
This guide is related to `/step3 - using_native_tools.md`

PR-URL: #31501
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
doc: guide - using valgrind to debug memory leaks
693b5d6 
Add doc for using valgrind to debug native
memory leaks.

Started writing this up as part of an effort
in the Diagnostic WG but think it's better
to have it in the core guides and then be referenced
by the docs in the Diagnostic WG repo.

For more details on the Diagnostic WG effort see
nodejs/diagnostics#254 (comment)
This guide is related to `/step3 - using_native_tools.md`

PR-URL: #31501
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
doc: guide - using valgrind to debug memory leaks
de275d0 
Add doc for using valgrind to debug native
memory leaks.

Started writing this up as part of an effort
in the Diagnostic WG but think it's better
to have it in the core guides and then be referenced
by the docs in the Diagnostic WG repo.

For more details on the Diagnostic WG effort see
nodejs/diagnostics#254 (comment)
This guide is related to `/step3 - using_native_tools.md`

PR-URL: #31501
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
mhdawson deleted the valgrind branch September 14, 2020 21:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott left review comments
addaleax addaleax left review comments
cjihrig cjihrig left review comments
jasnell jasnell approved these changes
gireeshpunathil gireeshpunathil approved these changes
+4 more reviewers
mscdex mscdex left review comments
XhmikosR XhmikosR left review comments
hekike hekike approved these changes
lundibundi lundibundi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL