Where is upstream in this context? If you've pulled gyp from the embedded version in node-gyp then there's #30563 (which has unresolved issues since the gyp code in node-gyp and the gyp code here in core have diverged).

https://github.com/nodejs/node/pull/31562/checks?check_run_id=414343479 is showing as passed but it actually failed:

Run ./vcbuild.bat
Looking for Python
Python found in C:\hostedtoolcache\windows\Python\3.6.8\x64\\python.exe
Looking for NASM
Looking for Visual Studio 2019
calling: "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\\Auxiliary\Build\vcvarsall.bat" amd64
**********************************************************************
** Visual Studio 2019 Developer Command Prompt v16.4.3
** Copyright (c) 2019 Microsoft Corporation
**********************************************************************
[vcvarsall.bat] Environment initialized for: 'x64'
Found MSVS version 16.0
configure  --dest-cpu=x64
Node.js configure: Found Python 3.6.8...
Traceback (most recent call last):
  File "configure", line 26, in <module>
    import configure
  File "D:\a\node\node\configure.py", line 1770, in <module>
    run_gyp(gyp_args)
  File "tools\gyp_node.py", line 54, in run_gyp
    rc = gyp.main(args)
  File "tools\gyp\pylib\gyp\__init__.py", line 547, in main
    return gyp_main(args)
  File "tools\gyp\pylib\gyp\__init__.py", line 523, in gyp_main
    options.duplicate_basename_check)
   File "tools\gyp\pylib\gyp\__init__.py", line 107, in Load
    generator.CalculateVariables(default_variables, params)
  File "tools\gyp\pylib\gyp\generator\msvs.py", line 1927, in CalculateVariables
    generator_flags.get('msvs_version', 'auto'))
  File "tools\gyp\pylib\gyp\MSVSVersion.py", line 446, in SelectVisualStudioVersion
    versions = _DetectVisualStudioVersions(version_map[version], 'e' in version)
KeyError: '2019'
Failed to create vc project files.

Where is upstream in this context? If you've pulled gyp from the embedded version in node-gyp then there's #30563 (which has unresolved issues since the gyp code in node-gyp and the gyp code here in core have diverged).

Missed this part, Thanks.

nodejs/node/pull/31562/checks?check_run_id=414343479 is showing as passed but it actually failed:

Run ./vcbuild.bat
Looking for Python
Python found in C:\hostedtoolcache\windows\Python\3.6.8\x64\\python.exe
Looking for NASM
Looking for Visual Studio 2019
calling: "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\\Auxiliary\Build\vcvarsall.bat" amd64
**********************************************************************
** Visual Studio 2019 Developer Command Prompt v16.4.3
** Copyright (c) 2019 Microsoft Corporation
**********************************************************************
[vcvarsall.bat] Environment initialized for: 'x64'
Found MSVS version 16.0
configure  --dest-cpu=x64
Node.js configure: Found Python 3.6.8...
Traceback (most recent call last):
  File "configure", line 26, in <module>
    import configure
  File "D:\a\node\node\configure.py", line 1770, in <module>
    run_gyp(gyp_args)
  File "tools\gyp_node.py", line 54, in run_gyp
    rc = gyp.main(args)
  File "tools\gyp\pylib\gyp\__init__.py", line 547, in main
    return gyp_main(args)
  File "tools\gyp\pylib\gyp\__init__.py", line 523, in gyp_main
    options.duplicate_basename_check)
   File "tools\gyp\pylib\gyp\__init__.py", line 107, in Load
    generator.CalculateVariables(default_variables, params)
  File "tools\gyp\pylib\gyp\generator\msvs.py", line 1927, in CalculateVariables
    generator_flags.get('msvs_version', 'auto'))
  File "tools\gyp\pylib\gyp\MSVSVersion.py", line 446, in SelectVisualStudioVersion
    versions = _DetectVisualStudioVersions(version_map[version], 'e' in version)
KeyError: '2019'
Failed to create vc project files.

Looks like need to get nodejs/node-gyp#1975 merged first.

I don't have time to look into it but we should look into why the job passed when it failed to run the configure script. (If someone does have time to look into it maybe see whether running the batch file via PowerShell is losing the exit code from the batch file.)