| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
//cc @nodejs/modules-active-members |
Sorry, something went wrong.
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
|
Thanks @addaleax for the review here, would appreciate your advice re how to properly do the check handling. |
Sorry, something went wrong.
|
@addaleax I've added all the checks you mentioned here now. Better docs / info around how exactly to these sorts of cases properly would definitely be useful for future reference. |
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
PR-URL: #31625 Reviewed-By: Jan Krems <jan.krems@gmail.com>
|
The CITGM failures were tracked down to causes unrelated to this PR in nodejs/citgm#785 (comment). |
Sorry, something went wrong.
PR-URL: #31625 Reviewed-By: Jan Krems <jan.krems@gmail.com>
|
@guybedford if this is something that should be in v12.x can you please manually backport it? Feel free to swap the label with a dont-land if that's not the case. |
Sorry, something went wrong.
|
@codebytere thanks for letting me know about this - backport PR at #32287. |
Sorry, something went wrong.
This error happens by this change in [Node,js v13.10](nodejs/node#31625) and I think we can regard this problem as the regression of this library. For the future, we should wait nodejs/node#32107 but it is still in progress. This patch will try to workaround for it. ## Reference * nodejs/node#31625 * nodejs/node#32107 * babel/babel#11216
This error happens by this change in [Node,js v13.10](nodejs/node#31625) and I think we can regard this problem as the regression of this library. For the future, we should wait nodejs/node#32107 but it is still in progress. This patch will try to workaround for it. * nodejs/node#31625 * nodejs/node#32107 * babel/babel#11216
PR-URL: nodejs#31625 Reviewed-By: Jan Krems <jan.krems@gmail.com>
PR-URL: nodejs#31625 Reviewed-By: Jan Krems <jan.krems@gmail.com>
| Back | FazBrowse Home | New Git URL |
This PR includes a number of refinements to the error handling of exports resolutions in the ES module resolver:
The main semantic changes in this PR are then the following:
Since its original proposal, "exports" has very much turned into a full replacement for "main". Having self-resolve entirely reliant on this field being set is also in line with this. I understand (2) may be the most controversial part of this PR with the biggest user-facing consequences, so I expect we should discuss this further in the next meeting. This PR can be adjusted further based on any resolutions. The logic connects around the error handling hence the monolith here.
In addition, this PR fixes #31510 and the incorrect use of XOR instead of bit shift described in #31008 (review).
Checklist