FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix #31650 right use of string and bytes objects by bioinfornatics · Pull Request #31659 · nodejs/node · GitHub

/ node Public

fix #31650 right use of string and bytes objects - #31659

Closed
bioinfornatics wants to merge 5 commits into
nodejs:masterfrom
bioinfornatics:icutrim
ConversationCommits (5)ChecksFiles changed
Closed

fix #31650 right use of string and bytes objects#31659
bioinfornatics wants to merge 5 commits into
nodejs:masterfrom
bioinfornatics:icutrim

Conversation

bioinfornatics commented Feb 6, 2020 •
edited by srl295
Loading

Copy link
Copy Markdown

Fixes: #31650

Checklist

  • [ x] make -j4 test (UNIX), or vcbuild test (Windows) passes

  • [x ] commit message follows commit guidelines

nodejs-github-bot added i18n-api Issues and PRs related to the i18n implementation. tools Issues and PRs related to the tools directory. labels Feb 6, 2020
addaleax requested a review from cclauss February 6, 2020 12:41
addaleax added the python PRs and issues that require attention from people who are familiar with Python. label Feb 6, 2020

Trott commented Feb 6, 2020

Copy link
Copy Markdown
Member

@nodejs/python

richardlau linked an issue Feb 6, 2020 that may be closed by this pull request
build nodejs 13.7.0 fail while invoking "icutrim.py" #31650
Closed
addaleax reviewed Feb 7, 2020
View reviewed changes
Comment thread tools/icu/icutrim.py Outdated
bnoordhuis reviewed Feb 8, 2020
View reviewed changes
Comment thread tools/icu/icutrim.py Outdated
aqrln reviewed Feb 27, 2020
View reviewed changes
Comment thread tools/icu/icutrim.py Outdated
cclauss requested changes Feb 27, 2020
View reviewed changes
Comment thread tools/icu/icutrim.py Outdated
cclauss reviewed Feb 27, 2020
View reviewed changes
Comment thread tools/icu/icutrim.py Outdated
bioinfornatics changed the title fix #31650i right use of string and bytes objects fix #31650 right use of string and bytes objects Mar 2, 2020

bioinfornatics commented Mar 4, 2020

Copy link
Copy Markdown
Author

Thanks everybody for your help! 👍

cclauss commented Mar 4, 2020

Copy link
Copy Markdown
Contributor

@nodejs/python

sam-github approved these changes Mar 4, 2020
View reviewed changes

sam-github left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM. Note to landers... the PR will need to be squashed and the commit message rewritten to match the commit guidelines: https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines

@bioinfornatics you can rebase, squash, fix the message, and force-push the branch yourself, or if you aren't comfortable with that, it can be done during landing.

nodejs-github-bot commented Mar 4, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29547/

sgallagher commented Mar 18, 2020

Copy link
Copy Markdown
Contributor

LGTM. I'm currently carrying this patch in Fedora to allow building on systems with no python2.

jasnell pushed a commit that referenced this pull request Mar 18, 2020
tools: fixup icutrim.py use of string and bytes objects
5f0af2a 
PR-URL: #31659
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

jasnell commented Mar 18, 2020

Copy link
Copy Markdown
Member

Landed in a squashed commit 5f0af2a

jasnell closed this Mar 18, 2020

cclauss commented Mar 18, 2020

Copy link
Copy Markdown
Contributor

@bioinfornatics and team, thanks for your perseverance on this one... It is good that it has landed.

cclauss mentioned this pull request Mar 19, 2020
Closed
2 tasks
srl295 reviewed Mar 19, 2020
View reviewed changes

srl295 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

post merge LGTM… Will have to figure out how to rebase #32347 though.

srl295 mentioned this pull request Mar 19, 2020
Closed
MylesBorins pushed a commit that referenced this pull request Mar 19, 2020
tools: fixup icutrim.py use of string and bytes objects
a7dabc5 
PR-URL: #31659
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins mentioned this pull request Mar 19, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
tools: fixup icutrim.py use of string and bytes objects
dedd219 
PR-URL: #31659
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos pushed a commit that referenced this pull request Apr 22, 2020
tools: fixup icutrim.py use of string and bytes objects
baf56f8 
PR-URL: #31659
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos mentioned this pull request Apr 22, 2020
Merged
srl295 mentioned this pull request Sep 24, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

srl295 srl295 left review comments
addaleax addaleax left review comments
cclauss cclauss approved these changes
bnoordhuis bnoordhuis approved these changes
+2 more reviewers
aqrln aqrln left review comments
sam-github sam-github approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

i18n-api Issues and PRs related to the i18n implementation. python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

build nodejs 13.7.0 fail while invoking "icutrim.py"
Back | FazBrowse Home | New Git URL