doc: update zlib doc - #31665
Closed
jasnell wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
mcollina
reviewed
Feb 6, 2020
Comment thread
doc/api/zlib.md
Outdated
Comment thread
doc/api/zlib.md
Outdated
Comment thread
doc/api/zlib.md
Outdated
jasnell
commented
Feb 6, 2020
Comment thread
doc/api/zlib.md
Outdated
lpinca
reviewed
Feb 6, 2020
Comment thread
doc/api/zlib.md
Outdated
lpinca
reviewed
Feb 6, 2020
Comment thread
doc/api/zlib.md
Outdated
addaleax
reviewed
Feb 6, 2020
Comment thread
doc/api/zlib.md
Outdated
Comment thread
doc/api/zlib.md
Outdated
Comment thread
doc/api/zlib.md
Outdated
addaleax
approved these changes
Feb 7, 2020
lpinca
approved these changes
Feb 7, 2020
Trott
reviewed
Feb 7, 2020
Comment thread
doc/api/zlib.md
Outdated
Trott
reviewed
Feb 7, 2020
Comment thread
doc/api/zlib.md
Outdated
Trott
reviewed
Feb 7, 2020
Comment thread
doc/api/zlib.md
Outdated
Trott
reviewed
Feb 7, 2020
Comment thread
doc/api/zlib.md
Outdated
Trott
reviewed
Feb 7, 2020
Comment thread
doc/api/zlib.md
Outdated
Trott
reviewed
Feb 7, 2020
Comment thread
doc/api/zlib.md
Outdated
Trott
reviewed
Feb 7, 2020
Comment thread
doc/api/zlib.md
Outdated
Trott
reviewed
Feb 7, 2020
Comment thread
doc/api/zlib.md
Outdated
Trott
reviewed
Feb 7, 2020
Comment thread
doc/api/zlib.md
Outdated
Trott
reviewed
Feb 7, 2020
Comment thread
doc/api/zlib.md
Outdated
jasnell
commented
Feb 17, 2020
Comment thread
doc/api/zlib.md
Outdated
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
addaleax
approved these changes
Feb 25, 2020
addaleax
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Still LGTM
Sorry, something went wrong.
Comment thread
doc/api/zlib.md
Outdated
jasnell
commented
Feb 26, 2020
Comment thread
doc/api/zlib.md
Outdated
Copy link
Copy Markdown
Member
Author
|
CI-Lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4135/ Trying again: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4136/ |
Sorry, something went wrong.
Just some general improvements to zlib docs and examples Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
update-zlib-docs
branch
from
c511798 to
919651b
Compare
February 27, 2020 00:25
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
added a commit
that referenced
this pull request
Feb 27, 2020
Just some general improvements to zlib docs and examples Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #31665 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Copy link
Copy Markdown
Member
Not sure if this was kicked off for some other reason and you already are aware of this, but just in case: FYI we changed the landing rules and lite CI is generally not needed anymore if Travis passed. #30330 |
Sorry, something went wrong.
codebytere
pushed a commit
that referenced
this pull request
Feb 27, 2020
Just some general improvements to zlib docs and examples Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #31665 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 15, 2020
Just some general improvements to zlib docs and examples Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #31665 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
Just some general improvements to zlib docs and examples Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #31665 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 30, 2020
Just some general improvements to zlib docs and examples Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #31665 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some general improvements to zlib docs and examples