FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc,src,test: assign missing deprecation code by cjihrig · Pull Request #31674 · nodejs/node · GitHub

/ node Public

doc,src,test: assign missing deprecation code - #31674

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:doc
Feb 9, 2020
ConversationCommits (1)ChecksFiles changed
Merged

doc,src,test: assign missing deprecation code#31674
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:doc

Conversation

cjihrig commented Feb 7, 2020

Copy link
Copy Markdown
Contributor

Refs: #28396

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Feb 7, 2020
jasnell approved these changes Feb 7, 2020
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Doh! Thank you :-)

nodejs-github-bot commented Feb 9, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29042/

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 9, 2020

nodejs-github-bot commented Feb 9, 2020 •
edited by cjihrig
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29051/ 💚

doc,src,test: assign missing deprecation code
009a9c4 
PR-URL: nodejs#31674
Refs: nodejs#28396
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
cjihrig merged commit 009a9c4 into nodejs:master Feb 9, 2020

codebytere commented Feb 17, 2020

Copy link
Copy Markdown
Member

@cjihrig should this be backported to v13.x? It'll need manual if so.

cjihrig deleted the doc branch February 17, 2020 20:27

cjihrig commented Feb 17, 2020

Copy link
Copy Markdown
Contributor Author

I don't think so. It goes along with #28396, which is semver-major.

BethGriggs mentioned this pull request Apr 14, 2020
Merged
richardlau mentioned this pull request Jul 14, 2020
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
addaleax addaleax approved these changes
lpinca lpinca approved these changes
richardlau richardlau approved these changes
BridgeAR BridgeAR approved these changes
+1 more reviewer
devnexen devnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL