FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

readline: remove intermediate variable by cjihrig · Pull Request #31676 · nodejs/node · GitHub

/ node Public

readline: remove intermediate variable - #31676

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:positive
Feb 9, 2020
ConversationCommits (1)ChecksFiles changed
Merged

readline: remove intermediate variable#31676
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:positive

Conversation

cjihrig commented Feb 7, 2020

Copy link
Copy Markdown
Contributor

This commit removes an extra intermediate variable. This makes the call consistent with other uses of validateUint32() in the codebase.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the readline Issues and PRs related to the built-in readline module. label Feb 7, 2020
BridgeAR reviewed Feb 7, 2020
View reviewed changes

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I added the variable deliberately to indicate the meaning of it. It's otherwise not possible to know what true stands for. Instead of removing the variable, it's likely better to change other places to also indicate the passed through meaning.

lpinca commented Feb 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

It's otherwise not possible to know what true stands for

The reader needs to jump to validateUint32() definition, but it's there no?

BridgeAR commented Feb 9, 2020

Copy link
Copy Markdown
Member

@lpinca it's an indirection and IMO true and false are similar to magic numbers: ideally they are not used.

nodejs-github-bot commented Feb 9, 2020 •
edited by cjihrig
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29048/ 💛

cjihrig added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 9, 2020
readline: remove intermediate variable
efec681 
This commit removes an extrea intermediate variable. This
makes the call consistent with other uses of validateUint32()
in the codebase.

PR-URL: nodejs#31676
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
cjihrig merged commit efec681 into nodejs:master Feb 9, 2020
cjihrig deleted the positive branch February 9, 2020 16:07

cjihrig commented Feb 9, 2020

Copy link
Copy Markdown
Contributor Author

It's not really feasible to replace all uses of true and false throughout the codebase, and there is nothing special about validateUint32() (in fact it's an internal API), so I've gone ahead and landed this.

codebytere pushed a commit that referenced this pull request Feb 17, 2020
readline: remove intermediate variable
98f3028 
This commit removes an extrea intermediate variable. This
makes the call consistent with other uses of validateUint32()
in the codebase.

PR-URL: #31676
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere mentioned this pull request Feb 17, 2020
Merged

targos commented Apr 18, 2020

Copy link
Copy Markdown
Member

depends on #31318 to land on v12.x

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

BridgeAR BridgeAR left review comments
addaleax addaleax approved these changes
lpinca lpinca approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. readline Issues and PRs related to the built-in readline module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL