doc: document self-referencing a package name - #31680
Closed
giltayar wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
giltayar
force-pushed
the
self-reference-module
branch
from
d206dcb to
fb077ef
Compare
February 7, 2020 22:09
hybrist
approved these changes
Feb 7, 2020
hybrist
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks for adding this! Looks good, one thing that may be confusing.
Sorry, something went wrong.
Comment thread
doc/api/esm.md
Outdated
hybrist
reviewed
Feb 7, 2020
Comment thread
doc/api/esm.md
Outdated
Copy link
Copy Markdown
Contributor
|
/cc @nodejs/modules-active-members |
Sorry, something went wrong.
MylesBorins
approved these changes
Feb 7, 2020
MylesBorins
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Comment thread
doc/api/esm.md
Outdated
Comment thread
doc/api/esm.md
Outdated
Comment thread
doc/api/esm.md
Outdated
giltayar
force-pushed
the
self-reference-module
branch
from
6d38758 to
256fe12
Compare
February 8, 2020 00:04
Comment thread
doc/api/esm.md
Outdated
Copy link
Copy Markdown
Contributor
Author
|
Not sure about the protocol, and there's nothing in the guidelines about this: should I squash the commits? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Yes, I think this PR would be appropriate for squashing. The commit message should follow the guidelines, such as starting with module: doc:. |
Sorry, something went wrong.
giltayar
force-pushed
the
self-reference-module
branch
from
b942e48 to
0873607
Compare
February 13, 2020 13:42
Copy link
Copy Markdown
Contributor
Author
|
Rebased and squashed. |
Sorry, something went wrong.
Comment thread
doc/api/esm.md
Outdated
GeoffreyBooth
approved these changes
Feb 13, 2020
Added a section for "Self-referencing a package using its name" that documents importing a package's own exports (this was missed when adding the feature).
giltayar
force-pushed
the
self-reference-module
branch
from
302d8d6 to
b260d06
Compare
February 13, 2020 21:37
Copy link
Copy Markdown
Contributor
|
Sorry for losing track of this. I assume this is good to land. I plan to do it at some point this week if nobody else beats me to it. |
Sorry, something went wrong.
addaleax
pushed a commit
that referenced
this pull request
Mar 9, 2020
Added a section for "Self-referencing a package using its name" that documents importing a package's own exports (this was missed when adding the feature). PR-URL: #31680 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2020
Added a section for "Self-referencing a package using its name" that documents importing a package's own exports (this was missed when adding the feature). PR-URL: #31680 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
Added a section for "Self-referencing a package using its name" that documents importing a package's own exports (this was missed when adding the feature). PR-URL: #31680 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 23, 2020
Added a section for "Self-referencing a package using its name" that documents importing a package's own exports (this was missed when adding the feature). PR-URL: #31680 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 30, 2020
Added a section for "Self-referencing a package using its name" that documents importing a package's own exports (this was missed when adding the feature). PR-URL: #31680 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a section for "Self-referencing a package using its name" that documents
importing a package's own exports (this was missed when adding the feature).
Checklist