FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix test-benchmark-http by Trott · Pull Request #31686 · nodejs/node · GitHub

/ node Public

test: fix test-benchmark-http - #31686

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:fix-bench-test
Feb 8, 2020
ConversationCommits (1)ChecksFiles changed
Merged

test: fix test-benchmark-http#31686
Trott merged 1 commit into
nodejs:masterfrom
Trott:fix-bench-test

Conversation

Trott commented Feb 7, 2020

Copy link
Copy Markdown
Member

fe39757 added a setting to a benchmark
which needs to be reflected in the test.

I'd like to fast-track this to fix the node-daily-master CI run. Collaborators, please 👍 here to approve.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 7, 2020
nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 7, 2020

nodejs-github-bot commented Feb 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28999/

Trott commented Feb 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Benchmark CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12075/ ✅

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 7, 2020

nodejs-github-bot commented Feb 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29004/

nodejs-github-bot commented Feb 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29015/

richardlau commented Feb 7, 2020

Copy link
Copy Markdown
Member

Did the same change land on all release lines? If so we should make sure this lands on those too. cc @nodejs/releasers

test: fix test-benchmark-http
8a14884 
fe39757 added a setting to a benchmark
which needs to be reflected in the test.

PR-URL: nodejs#31686
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Trott merged commit 8a14884 into nodejs:master Feb 8, 2020

Trott commented Feb 8, 2020

Copy link
Copy Markdown
Member Author

Landed in 8a14884

Trott deleted the fix-bench-test branch February 8, 2020 02:49
richardlau mentioned this pull request Feb 8, 2020
Merged
codebytere pushed a commit that referenced this pull request Feb 17, 2020
test: fix test-benchmark-http
3bcc2da 
fe39757 added a setting to a benchmark
which needs to be reflected in the test.

PR-URL: #31686
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
test: fix test-benchmark-http
7670333 
fe39757 added a setting to a benchmark
which needs to be reflected in the test.

PR-URL: #31686
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
test: fix test-benchmark-http
76991fb 
fe39757 added a setting to a benchmark
which needs to be reflected in the test.

PR-URL: #31686
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
test: fix test-benchmark-http
bdd1133 
fe39757 added a setting to a benchmark
which needs to be reflected in the test.

PR-URL: #31686
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
richardlau richardlau approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL