FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

vm: lazily initialize primordials for vm contexts by joyeecheung · Pull Request #31738 · nodejs/node · GitHub

/ node Public

vm: lazily initialize primordials for vm contexts - #31738

Closed
joyeecheung wants to merge 2 commits into
nodejs:masterfrom
joyeecheung:no-primordials-for-context
ConversationCommits (2)ChecksFiles changed
Closed

vm: lazily initialize primordials for vm contexts#31738
joyeecheung wants to merge 2 commits into
nodejs:masterfrom
joyeecheung:no-primordials-for-context

Conversation

joyeecheung commented Feb 11, 2020

Copy link
Copy Markdown
Member

Lazily initialize primordials when cross-context support for
builtins is needed to fix the performance regression in context
creation.

Fixes: #29842

local benchmark results

                            confidence improvement accuracy (*)    (**)   (***)
 vm/create-context.js n=100        ***    485.26 %      ±15.48% ±21.32% ±29.29%
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

vm: lazily initialize primordials for vm contexts
d6b9d2a 
Lazily initialize primordials when cross-context support for
builtins is needed to fix the performance regression in context
creation.
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. vm Issues and PRs related to the vm subsystem. labels Feb 11, 2020
joyeecheung commented Feb 11, 2020
View reviewed changes
Comment thread src/api/environment.cc
return InitializePrimordials(context);
}

bool InitializePrimordials(Local<Context> context) {

joyeecheung Feb 11, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This block contains only indentation change

nodejs-github-bot commented Feb 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29072/

joyeecheung commented Feb 11, 2020
View reviewed changes
Comment thread src/api/environment.cc Outdated
Local<Object> exports = Object::New(isolate);
if (context->Global()->SetPrivate(context, key, exports).IsNothing())
return MaybeLocal<Object>();
InitializePrimordials(context);

joyeecheung Feb 11, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is only hit for vm contexts and main contexts created without snapshot support so there's no additional cost for the main context built with snapshot support

joyeecheung commented Feb 11, 2020

Copy link
Copy Markdown
Member Author

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/522/

joyeecheung commented Feb 11, 2020
View reviewed changes
Comment thread src/api/environment.cc
Local<Object> exports = Object::New(isolate);
if (context->Global()->SetPrivate(context, key, exports).IsNothing())
if (context->Global()->SetPrivate(context, key, exports).IsNothing() ||
!InitializePrimordials(context))

joyeecheung Feb 11, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oops, forgot to handle the return value of InitializePrimordials in the initial commit, fixed.

addaleax commented Feb 13, 2020

Copy link
Copy Markdown
Member 
16:41:47                             confidence improvement accuracy (*)    (**)   (***)
16:41:47  vm/create-context.js n=100        ***    371.94 %      ±21.00% ±28.29% ±37.54%

🙂

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 13, 2020

nodejs-github-bot commented Feb 13, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29109/

joyeecheung added a commit that referenced this pull request Feb 19, 2020
vm: lazily initialize primordials for vm contexts
e6c2277 
Lazily initialize primordials when cross-context support for
builtins is needed to fix the performance regression in context
creation.

PR-URL: #31738
Fixes: #29842
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>

joyeecheung commented Feb 19, 2020

Copy link
Copy Markdown
Member Author

Landed in e6c2277. Thanks!

codebytere pushed a commit that referenced this pull request Feb 27, 2020
vm: lazily initialize primordials for vm contexts
a86cb0e 
Lazily initialize primordials when cross-context support for
builtins is needed to fix the performance regression in context
creation.

PR-URL: #31738
Fixes: #29842
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
codebytere mentioned this pull request Feb 29, 2020
Merged

codebytere commented Mar 15, 2020

Copy link
Copy Markdown
Member

@joyeecheung if this should go to v12.x can you please open a manual backport? There are some conflicts i'd rather not chance myself.

targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
vm: lazily initialize primordials for vm contexts
c648729 
Lazily initialize primordials when cross-context support for
builtins is needed to fix the performance regression in context
creation.

PR-URL: nodejs#31738
Fixes: nodejs#29842
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2020
vm: lazily initialize primordials for vm contexts
02de66a 
Lazily initialize primordials when cross-context support for
builtins is needed to fix the performance regression in context
creation.

PR-URL: #31738
Fixes: #29842
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
targos mentioned this pull request May 2, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
+2 more reviewers
devnexen devnexen approved these changes
devsnek devsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Significant slowdown of createContext and runInContext

7 participants

Back | FazBrowse Home | New Git URL