src: stop calling deprecated noop method - #31774
Closed
MarshallOfSound wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This method was removed in V8 here https://chromium-review.googlesource.com/c/v8/v8/+/2033169 and has been a noop for a while
addaleax
approved these changes
Feb 13, 2020
codebytere
approved these changes
Feb 13, 2020
BridgeAR
approved these changes
Feb 13, 2020
lpinca
approved these changes
Feb 13, 2020
devsnek
approved these changes
Feb 13, 2020
jasnell
approved these changes
Feb 13, 2020
devnexen
approved these changes
Feb 14, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@MarshallOfSound this does not appear to be a noop after all: 08:05:55 not ok 2295 parallel/test-v8-serdes 08:05:55 --- 08:05:55 duration_ms: 0.95 08:05:55 severity: fail 08:05:55 exitcode: 1 08:05:55 stack: |- 08:05:55 /Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1011/test/parallel/test-v8-serdes.js:48 08:05:55 assert.deepStrictEqual(des.readValue(), obj); 08:05:55 ^ 08:05:55 08:05:55 Error: Unable to deserialize cloned data. 08:05:55 at Object.<anonymous> (/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1011/test/parallel/test-v8-serdes.js:48:32) 08:05:55 at Module._compile (internal/modules/cjs/loader.js:1206:30) 08:05:55 at Object.Module._extensions..js (internal/modules/cjs/loader.js:1226:10) 08:05:55 at Module.load (internal/modules/cjs/loader.js:1055:32) 08:05:55 at Function.Module._load (internal/modules/cjs/loader.js:950:14) 08:05:55 at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12) 08:05:55 at internal/main/run_main_module.js:17:47 failed deterministically across platforms |
Sorry, something went wrong.
fhinkel
approved these changes
Apr 21, 2020
Copy link
Copy Markdown
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/30971/ (:green_heart:) |
Sorry, something went wrong.
targos
approved these changes
Apr 25, 2020
targos
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
It is a noop on master now
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Looks like this already happened in #32116. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method was removed in V8 here https://chromium-review.googlesource.com/c/v8/v8/+/2033169 and has been a noop for a while
Checklist