doc: improve doc/markdown file organization coherence - #31792
Closed
DavenportEmma wants to merge 10 commits into
Closed
doc: improve doc/markdown file organization coherence#31792DavenportEmma wants to merge 10 commits into
DavenportEmma wants to merge 10 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jasnell
reviewed
Feb 14, 2020
Comment thread
README.md
Outdated
jasnell
approved these changes
Feb 14, 2020
Copy link
Copy Markdown
Contributor
|
What happened to #31771 ? In the futre, please don't create duplicate PRs, its confusing, and loses the conversation history. |
Sorry, something went wrong.
sam-github
reviewed
Feb 14, 2020
sam-github
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
A couple small suggestions. Please do not close this branch or the PR. Make any changes you need to locally, and force push the branch to update the PR. Thanks!
Sorry, something went wrong.
Comment thread
benchmark/README.md
Outdated
Comment thread
doc/guides/contributing/pull-requests.md
Outdated
Copy link
Copy Markdown
Member
@sam-github ... yeah, @conordavenport is still getting the hang of git ;-) ... we'll get him sorted on that soon! |
Sorry, something went wrong.
richardlau
reviewed
Feb 14, 2020
Comment thread
GOVERNANCE.md
Outdated
Updated cpp style guide file name and location and fixed links to this file. Fixes: nodejs#31741
Updated collaborator guide file name and location and fixed links to this file. Fixes: nodejs#31741
Updated documentation style guide file name and location and updated links referencing the file. Fixes: nodejs#31741
Fixed the links referencing markdown files that have moved location Fixes: nodejs#31741
Moved files to appropriate location and updated naming style for some of them. Fixes: nodejs#31741
Reduced line length for linter
Co-Authored-By: James M Snell <jasnell@gmail.com>
DavenportEmma
force-pushed
the
issue31741
branch
from
4d8f89b to
bec8a74
Compare
February 27, 2020 16:45
sam-github
approved these changes
Mar 2, 2020
Copy link
Copy Markdown
Contributor
|
Thanks @conordavenport , I kicked off a ci-lite, then it should be landable. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
addaleax
pushed a commit
that referenced
this pull request
Mar 4, 2020
* Updated cpp style guide file name and location and fixed links to this file. * Updated collaborator guide file name and location and fixed links to this file. * Updated documentation style guide file name and location and updated links referencing the file. * Moved files to appropriate location and updated naming style for some of them. Fixes: #31741 PR-URL: #31792 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 4, 2020
* Updated cpp style guide file name and location and fixed links to this file. * Updated collaborator guide file name and location and fixed links to this file. * Updated documentation style guide file name and location and updated links referencing the file. * Moved files to appropriate location and updated naming style for some of them. Fixes: #31741 PR-URL: #31792 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 16, 2020
* Updated cpp style guide file name and location and fixed links to this file. * Updated collaborator guide file name and location and fixed links to this file. * Updated documentation style guide file name and location and updated links referencing the file. * Moved files to appropriate location and updated naming style for some of them. Fixes: #31741 PR-URL: #31792 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
* Updated cpp style guide file name and location and fixed links to this file. * Updated collaborator guide file name and location and fixed links to this file. * Updated documentation style guide file name and location and updated links referencing the file. * Moved files to appropriate location and updated naming style for some of them. Fixes: #31741 PR-URL: #31792 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 23, 2020
* Updated cpp style guide file name and location and fixed links to this file. * Updated collaborator guide file name and location and fixed links to this file. * Updated documentation style guide file name and location and updated links referencing the file. * Moved files to appropriate location and updated naming style for some of them. Fixes: #31741 PR-URL: #31792 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 30, 2020
* Updated cpp style guide file name and location and fixed links to this file. * Updated collaborator guide file name and location and fixed links to this file. * Updated documentation style guide file name and location and updated links referencing the file. * Moved files to appropriate location and updated naming style for some of them. Fixes: #31741 PR-URL: #31792 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve markdown and documentation file organization.
Fixes: #31741
Checklist