FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: inform callback scopes about exceptions in HTTP parser by addaleax · Pull Request #31801 · nodejs/node · GitHub

/ node Public

src: inform callback scopes about exceptions in HTTP parser - #31801

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:http-parser-callbackscope
ConversationCommits (1)ChecksFiles changed
Closed

src: inform callback scopes about exceptions in HTTP parser#31801
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:http-parser-callbackscope

Conversation

addaleax commented Feb 14, 2020

Copy link
Copy Markdown
Member

Refs: 4aca277
Refs: #30236
Fixes: #31796

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. labels Feb 14, 2020
addaleax mentioned this pull request Feb 14, 2020
Closed

nodejs-github-bot commented Feb 14, 2020 •
edited by addaleax
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29141/ (:white_check_mark:)

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 15, 2020
MylesBorins mentioned this pull request Feb 18, 2020
Closed
2 tasks
addaleax added a commit that referenced this pull request Feb 18, 2020
src: inform callback scopes about exceptions in HTTP parser
fab3eff 
Refs: 4aca277
Refs: #30236
Fixes: #31796

PR-URL: #31801
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>

addaleax commented Feb 18, 2020

Copy link
Copy Markdown
Member Author

Landed in fab3eff

addaleax closed this Feb 18, 2020
addaleax deleted the http-parser-callbackscope branch February 18, 2020 01:58
MylesBorins pushed a commit that referenced this pull request Feb 18, 2020
src: inform callback scopes about exceptions in HTTP parser
42b68a4 
Refs: 4aca277
Refs: #30236
Fixes: #31796

PR-URL: #31801
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
This was referenced Feb 18, 2020
Merged
Closed
codebytere pushed a commit that referenced this pull request Feb 27, 2020
src: inform callback scopes about exceptions in HTTP parser
98d262e 
Refs: 4aca277
Refs: #30236
Fixes: #31796

PR-URL: #31801
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
codebytere mentioned this pull request Feb 29, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
+1 more reviewer
devnexen devnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12.16/13.8: http response listener throwing does not result in emit of uncaughtException

4 participants

Back | FazBrowse Home | New Git URL