FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

net: autoDestroy Socket by ronag · Pull Request #31806 · nodejs/node · GitHub

/ node Public

net: autoDestroy Socket - #31806

Closed
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:net-use-autodestroy
ConversationCommits (1)ChecksFiles changed
Closed

net: autoDestroy Socket#31806
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:net-use-autodestroy

Conversation

ronag commented Feb 15, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Refactors net.Socket into using autoDestroy functionality of streams.

During this refactoring due to slightly different timing of things other bugs got activated and needed to be resolved.

Also, the behaviour of net.Socket and stream.Duplex needed to be consolidated to have the same generic behaviour in terms of allowHalfOpen.

Also fixes a close vs shutdown race #32486 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

ronag added net Issues and PRs related to the net subsystem. stream Issues and PRs related to the stream subsystem. labels Feb 15, 2020

nodejs-github-bot commented Feb 15, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29143/

ronag force-pushed the net-use-autodestroy branch from 0117c05 to daabdb1 Compare February 15, 2020 01:23

nodejs-github-bot commented Feb 15, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29145/

ronag commented Feb 15, 2020

Copy link
Copy Markdown
Member Author

If backporting autoDestroy would have to be explicitly set to true.

mcollina added the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 15, 2020
mcollina approved these changes Feb 15, 2020
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

mcollina commented Feb 15, 2020

Copy link
Copy Markdown
Member

I prefer this to land as a semver-major commit.

nodejs-github-bot commented Feb 15, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29150/

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 15, 2020

nodejs-github-bot commented Feb 16, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29164/

lpinca previously approved these changes Feb 16, 2020
View reviewed changes

nodejs-github-bot commented Apr 1, 2020 •
edited by ronag
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30332/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2330/

CITGM (master to compare): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2331/

ronag commented Apr 1, 2020

Copy link
Copy Markdown
Member Author

CI passes

ronag added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 1, 2020

ronag commented Apr 1, 2020

Copy link
Copy Markdown
Member Author

@mcollina @benjamingr PTAL @addaleax

mcollina approved these changes Apr 1, 2020
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

ronag commented Apr 2, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Seems to be quite a bit of failures on CITGM though I don't think they are related to this PR. I'd appreciate a second opinion @Trott @MylesBorins. #31806 (comment)

ronag commented Apr 2, 2020

Copy link
Copy Markdown
Member Author

Nevermind, CITGM looks good. This PR actually has fever failures than master (for some reason?).

mcollina commented Apr 2, 2020

Copy link
Copy Markdown
Member

@nodejs/tsc this needs another approval.

addaleax approved these changes Apr 2, 2020
View reviewed changes
Comment thread test/parallel/test-http2-max-invalid-frames.js Outdated

addaleax Apr 2, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I’m not sure I understand why this is necessary either, but I agree that the test functionality shouldn’t be affected – the important thing is that the .once('error') handler below fires.

ronag commented Apr 2, 2020

Copy link
Copy Markdown
Member Author

Landed in efefdd6

ronag closed this Apr 2, 2020
ronag added a commit that referenced this pull request Apr 2, 2020
net: autoDestroy Socket
efefdd6 
Refactors net.Socket into using autoDestroy functionality
of streams.

PR-URL: #31806
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This was referenced Apr 12, 2020
Closed
Closed
ronag mentioned this pull request Apr 20, 2020
Closed
4 tasks
ronag mentioned this pull request Apr 28, 2020
Closed
4 tasks
Trott mentioned this pull request Jul 12, 2020
Closed
Trott added a commit to Trott/io.js that referenced this pull request Jul 12, 2020
test: fix flaky test-http2-reset-flood
9e95a46 
Set `allowHalfOpen: true` in the client.

Fixes: nodejs#29802
Refs: nodejs#31806
Trott mentioned this pull request Jul 12, 2020
Closed
2 tasks
addaleax pushed a commit that referenced this pull request Jul 14, 2020
test: fix flaky test-http2-reset-flood
4195c31 
Set `allowHalfOpen: true` in the client.

Fixes: #29802
Refs: #31806

PR-URL: #34318
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
test: fix flaky test-http2-reset-flood
c72585b 
Set `allowHalfOpen: true` in the client.

Fixes: #29802
Refs: #31806

PR-URL: #34318
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
test: fix flaky test-http2-reset-flood
28ce378 
Set `allowHalfOpen: true` in the client.

Fixes: #29802
Refs: #31806

PR-URL: #34318
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
test: fix flaky test-http2-reset-flood
9fa53b3 
Set `allowHalfOpen: true` in the client.

Fixes: #29802
Refs: #31806

PR-URL: #34318
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
BethGriggs mentioned this pull request Sep 1, 2020
Merged
flotwig mentioned this pull request Nov 9, 2021
Merged
This was referenced Jul 5, 2022
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
addaleax addaleax approved these changes
benjamingr benjamingr approved these changes
jasnell Awaiting requested review from jasnell
lundibundi Awaiting requested review from lundibundi
lpinca Awaiting requested review from lpinca

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. net Issues and PRs related to the net subsystem. semver-major PRs that contain breaking changes and should be released in the next major version. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL