FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: clarify http2.connect authority by jasnell · Pull Request #31828 · nodejs/node · GitHub

/ node Public

doc: clarify http2.connect authority - #31828

Closed
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:clarify-http2-connect-authority
ConversationCommits (2)ChecksFiles changed
Closed

doc: clarify http2.connect authority #31828
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:clarify-http2-connect-authority

Conversation

jasnell commented Feb 17, 2020

Copy link
Copy Markdown
Member

Clarify http2.connect authority parameter details

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Feb 17, 2020
jasnell mentioned this pull request Feb 17, 2020
Closed
szmarczak suggested changes Feb 17, 2020
View reviewed changes
Comment thread doc/api/http2.md
-->

* `authority` {string|URL}
* `authority` {string|URL} The remote HTTP/2 server to connect to. This must

This comment was marked as resolved.

Sign in to view

szmarczak commented Feb 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

I think I've already pointed out that the word authority is incorrectly used here, so redefining the meaning for Node.js won't change the RFC definition.

jasnell commented Feb 17, 2020

Copy link
Copy Markdown
Member Author

I'll look at changing to authority to origin in a separate PR. I want to go back and check what the name of the argument is in the source and change it there also if necessary to keep them in sync, just don't have the opportunity to do so yet.

jasnell added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 24, 2020
jasnell commented Feb 26, 2020
View reviewed changes
Comment thread doc/api/http2.md Outdated

jasnell commented Feb 26, 2020

Copy link
Copy Markdown
Member Author

CI-Lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4134/

jasnell added a commit that referenced this pull request Feb 27, 2020
doc: clarify http2.connect authority details
cbaae7a 
Fixes: #31827

PR-URL: #31828
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>

jasnell commented Feb 27, 2020

Copy link
Copy Markdown
Member Author

Landed in cbaae7a

jasnell closed this Feb 27, 2020
codebytere pushed a commit that referenced this pull request Feb 27, 2020
doc: clarify http2.connect authority details
8516602 
Fixes: #31827

PR-URL: #31828
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
codebytere mentioned this pull request Feb 29, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
doc: clarify http2.connect authority details
dc745e3 
Fixes: #31827

PR-URL: #31828
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
doc: clarify http2.connect authority details
ce1c681 
Fixes: #31827

PR-URL: #31828
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
doc: clarify http2.connect authority details
a1c0d46 
Fixes: #31827

PR-URL: #31828
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
ZYSzys ZYSzys approved these changes
+1 more reviewer
szmarczak szmarczak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL