stream: fix broken pipeline error propagation - #31835
Closed
ronag wants to merge 4 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ronag
commented
Feb 17, 2020
Comment thread
lib/internal/streams/pipeline.js
Outdated
ronag
commented
Feb 17, 2020
Comment thread
test/parallel/test-stream-pipeline.js
Outdated
ronag
force-pushed
the
stream-pipeline-broken-test
branch
from
2b052e0 to
ca5b7ff
Compare
February 17, 2020 20:29
mcollina
reviewed
Feb 19, 2020
Comment thread
test/parallel/test-stream-pipeline.js
Outdated
ronag
commented
Feb 19, 2020
Comment thread
lib/internal/streams/pipeline.js
Outdated
ronag
force-pushed
the
stream-pipeline-broken-test
branch
from
eae965f to
d1533fe
Compare
February 21, 2020 11:50
Copy link
Copy Markdown
Member
Author
|
Confusion resolved. There was a .catch(...) after .then(...) which was swallowing errors. @nodejs/streams PTAL |
Sorry, something went wrong.
ronag
force-pushed
the
stream-pipeline-broken-test
branch
from
22b2dd6 to
d0860a6
Compare
February 21, 2020 11:54
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
ronag
force-pushed
the
stream-pipeline-broken-test
branch
3 times, most recently
from
ce8e95d to
d3df498
Compare
February 21, 2020 13:47
If the destination was an async function any error thrown from that function would be swallowed.
ronag
force-pushed
the
stream-pipeline-broken-test
branch
from
d3df498 to
f07a2d1
Compare
February 21, 2020 18:15
benjamingr
approved these changes
Feb 22, 2020
benjamingr
reviewed
Feb 22, 2020
Comment thread
lib/internal/streams/pipeline.js
mcollina
approved these changes
Feb 22, 2020
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lundibundi
approved these changes
Feb 22, 2020
Comment thread
test/parallel/test-stream-pipeline-uncaught.js
Outdated
Comment thread
test/parallel/test-stream-pipeline-uncaught.js
Outdated
Co-Authored-By: Denys Otrishko <shishugi@gmail.com>
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
ronag
added a commit
that referenced
this pull request
Feb 24, 2020
If the destination was an async function any error thrown from that function would be swallowed. PR-URL: #31835 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Feb 27, 2020
If the destination was an async function any error thrown from that function would be swallowed. Backport-PR-URL: nodejs#31975 PR-URL: nodejs#31835 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Merged
Copy link
Copy Markdown
Member
|
Should this land on v12.x-staging? If so, please open a backport PR. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the destination was an async function any error thrown from that function would be swallowed.
EDITED
Checklist