events: convert errorMonitor to normal property - #31848
Closed
Flarna wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
legendecas
reviewed
Feb 18, 2020
Comment thread
lib/events.js
Outdated
Convert property errorMonitor to a normal property as non-writable caused unwanted side effects. Refs: nodejs#30932 (comment)
Flarna
force-pushed
the
events-error-monitor
branch
from
d1b498c to
e00a3fb
Compare
February 18, 2020 15:33
targos
approved these changes
Feb 21, 2020
4 tasks
lpinca
approved these changes
Feb 21, 2020
jasnell
approved these changes
Feb 21, 2020
mmarchini
approved these changes
Feb 21, 2020
Copy link
Copy Markdown
Member
Author
|
Friendly ping, would be nice if someone could move this forward. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Is there anything I can do for CI? I haven't found a way yet to retrigger it... |
Sorry, something went wrong.
4 tasks
addaleax
approved these changes
Feb 28, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
cjihrig
approved these changes
Feb 28, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Is there something I can do for CI? Does it help if I rebase? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I'll land this, the only failure is 08:29:22 not ok 650 known_issues/test-vm-timeout-escape-queuemicrotask 08:29:22 --- 08:29:22 duration_ms: 1.242 08:29:22 severity: fail 08:29:22 stack: |- 08:29:22 ... which is a known flaky (#32048) and won't be fixed (#31980). |
Sorry, something went wrong.
mmarchini
pushed a commit
that referenced
this pull request
Mar 2, 2020
Convert property errorMonitor to a normal property as non-writable caused unwanted side effects. Refs: #30932 (comment) PR-URL: #31848 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 4, 2020
Convert property errorMonitor to a normal property as non-writable caused unwanted side effects. Refs: #30932 (comment) PR-URL: #31848 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Copy link
Copy Markdown
Member
|
Yes. Sorry if I'm not giving enough details in these messages, but I have about 300 semver-patch commits to review to prepare the next v12.x release. |
Sorry, something went wrong.
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Convert property errorMonitor to a normal property as non-writable caused unwanted side effects. Refs: nodejs#30932 (comment) PR-URL: nodejs#31848 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
Convert property errorMonitor to a normal property as non-writable caused unwanted side effects. Refs: #30932 (comment) PR-URL: #31848 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert property errorMonitor to a normal property as non-writable caused unwanted side effects.
Refs: #30932 (comment)
Checklist