FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add entry for `AsyncHook` class by HarshithaKP · Pull Request #31865 · nodejs/node · GitHub

/ node Public

doc: add entry for AsyncHook class - #31865

Closed
HarshithaKP wants to merge 4 commits into
nodejs:masterfrom
HarshithaKP:asyc_hook_class_name
ConversationCommits (4)ChecksFiles changed
Closed

doc: add entry for AsyncHook class#31865
HarshithaKP wants to merge 4 commits into
nodejs:masterfrom
HarshithaKP:asyc_hook_class_name

Conversation

HarshithaKP commented Feb 19, 2020

Copy link
Copy Markdown
Member

fixes: #31661

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. labels Feb 19, 2020
addaleax reviewed Feb 19, 2020
View reviewed changes
Comment thread doc/api/async_hooks.md Outdated
addaleax reviewed Feb 20, 2020
View reviewed changes
Comment thread doc/api/async_hooks.md Outdated
Comment thread doc/api/async_hooks.md Outdated

addaleax Feb 20, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Either

Suggested change
it helps associating method calls that otherwise do not appear together
it helps with associating method calls that otherwise do not appear together

or

Suggested change
it helps associating method calls that otherwise do not appear together
it helps associate method calls that otherwise do not appear together

That being said – what’s a typical call stack?

HarshithaKP Feb 21, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@addaleax , I used typical here to mean a representative call stack on node.js program error. As per my understanding, a representative stack is a incomplete part of an asynchronous sequence. Am I wrong?

addaleax Mar 9, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@HarshithaKP I’m still confused… That kind of only moves the question from “what’s a typical call stack?” to “what’s a representative call stack?”.

To be honest, I think it’s okay to drop the second sentence here. The sentence is not accurate anyway, the IDs are unique per asynchronous resource but not per asynchronous call.

HarshithaKP Mar 9, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@addaleax, dropped the second sentence.

Trott commented Feb 21, 2020

Copy link
Copy Markdown
Member

@nodejs/documentation

(I'm feeling @vsemozhetbyt's absence these days. ❤️)

gireeshpunathil commented Mar 5, 2020

Copy link
Copy Markdown
Member

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4140/

gireeshpunathil added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 5, 2020
addaleax removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 9, 2020
BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 9, 2020
addaleax pushed a commit that referenced this pull request Mar 11, 2020
doc: add entry for AsyncHook class
e4a72d6 
fixes: #31661

PR-URL: #31865
Fixes: #31661
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax commented Mar 11, 2020

Copy link
Copy Markdown
Member

Landed in e4a72d6

addaleax closed this Mar 11, 2020
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
doc: add entry for AsyncHook class
3fa57ee 
fixes: #31661

PR-URL: #31865
Fixes: #31661
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Mar 12, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
doc: add entry for AsyncHook class
c439d83 
fixes: #31661

PR-URL: #31865
Fixes: #31661
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Apr 22, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Qard Qard approved these changes
jasnell jasnell approved these changes
addaleax addaleax approved these changes
BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

async_hooks doc missing AsyncHook class

8 participants

Back | FazBrowse Home | New Git URL