| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
they (v8) did have a (documented?) promise that they would consider Node's compatibility as a major factor while implementing features? |
Sorry, something went wrong.
|
@gireeshpunathil i'm pretty sure they don't consider this an issue with compat considering Node.js was piping straight through to V8's own bespoke option; we also already gate some --perf-prof options to linux, as you can see in the testfile, owing to similar changes upstream. |
Sorry, something went wrong.
|
--perf-prof doesn't make much sense on outside of Linux, as it generates a jitdump file. --perf-basic-prof on the other hand could be used on other platforms, since it is just a text file (I have used it on OS X in the past). Well, that's not really a Node.js issue though. I'll get in touch with V8 about that. |
Sorry, something went wrong.
|
ok, thanks @mmarchini, that will really help! for the context, my use case is here: https://github.com/nodejs/diagnostics/tree/master/documentation/profiling - attempt to document diagnostic best practices around profiling. These are aimed at user-journey driven, endorsed by node project, and planned to be supported for long term. as that is a conversation with v8, and this PR is just documenting the code behavior that was uncovered in the field, it looks good to me! |
Sorry, something went wrong.
Sorry, something went wrong.
PR-URL: #31892 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #31892 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #31892 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #31892 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #31892 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
| Back | FazBrowse Home | New Git URL |
--perf-prof-related flags have been removed in V8 on non-linux devices, and so we should note that in testing here as well as in docs.
See:
This broke in Electron, which is how i discovered it.
Checklist