FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: add asan check in Github action by gengjiawen · Pull Request #31902 · nodejs/node · GitHub

/ node Public

build: add asan check in Github action - #31902

Closed
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:ci/asan
ConversationCommits (1)ChecksFiles changed
Closed

build: add asan check in Github action#31902
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:ci/asan

Conversation

gengjiawen commented Feb 21, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

This related to #30257

This currently only runs on linux only. Acutally windows has made some progress on
this too, see https://devblogs.microsoft.com/cppblog/addresssanitizer-asan-for-windows-with-msvc/, but it require cmake as build toolchain IIUC. Also current code asan checks broken on macOS, so I didn't add them.

currrent Docker Image source: https://github.com/gengjiawen/node-build/blob/master/Dockerfile.

todo

Hopefully we can remove continue-on-error in the future.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Feb 21, 2020

bnoordhuis commented Feb 21, 2020

Copy link
Copy Markdown
Member

Seems like a good idea but how long does make test take for an asan+debug build?

richardlau commented Feb 21, 2020

Copy link
Copy Markdown
Member

Seems like a good idea but how long does make test take for an asan+debug build?

https://github.com/nodejs/node/pull/31902/checks?check_run_id=460428978 took 1 hr 40mins.

gengjiawen commented Feb 22, 2020

Copy link
Copy Markdown
Member Author

ASAN checks failed on first error (https://github.com/nodejs/node/runs/460428978?check_suite_focus=true), so I add ASAN_OPTIONS: halt_on_error=0 to run all the tests.

gengjiawen commented Feb 25, 2020

Copy link
Copy Markdown
Member Author

@bnoordhuis @addaleax @richardlau Can you review this ? thanks.

bnoordhuis approved these changes Feb 25, 2020
View reviewed changes

bnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM and thanks, this is useful!

To save everyone some clicking: it takes 205 minutes or about 3.5 hours for a full run. 1.5h is just the build itself though so maybe that can be sped up somehow.

nodejs-github-bot commented Feb 28, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29431/

nodejs-github-bot commented Feb 29, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29454/

nodejs-github-bot commented Mar 1, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29464/

gengjiawen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 1, 2020

nodejs-github-bot commented Mar 1, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29466/

gengjiawen added a commit that referenced this pull request Mar 3, 2020
build: add asan check in Github action
3ec4b21 
PR-URL: #31902
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

gengjiawen commented Mar 3, 2020

Copy link
Copy Markdown
Member Author

Landed in 3ec4b21

gengjiawen closed this Mar 3, 2020
gengjiawen deleted the ci/asan branch March 3, 2020 10:06
richardlau mentioned this pull request Mar 4, 2020
Merged
2 tasks
MylesBorins pushed a commit that referenced this pull request Mar 4, 2020
build: add asan check in Github action
478450d 
PR-URL: #31902
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins mentioned this pull request Mar 4, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 16, 2020
build: add asan check in Github action
64b328a 
PR-URL: #31902
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
build: add asan check in Github action
776b132 
PR-URL: #31902
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
codebytere mentioned this pull request Mar 17, 2020
Merged
sam-github mentioned this pull request Mar 17, 2020
Closed
gengjiawen mentioned this pull request Mar 20, 2020
Closed
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL