FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

standardizes references to 'userland' issue #3189 by MJefferson · Pull Request #3192 · nodejs/node · GitHub

/ node Public

standardizes references to 'userland' issue #3189 - #3192

Closed
MJefferson wants to merge 1 commit into
nodejs:masterfrom
MJefferson:standardize-userland
ConversationCommits (1)ChecksFiles changed
Closed

standardizes references to 'userland' issue #3189#3192
MJefferson wants to merge 1 commit into
nodejs:masterfrom
MJefferson:standardize-userland

Conversation

MJefferson commented Oct 5, 2015

Copy link
Copy Markdown
Contributor

Decided to standardize from "user-land" to "userland" as the latter appears more frequently in the docs.

Trott reviewed Oct 5, 2015
View reviewed changes
Comment thread CHANGELOG.md

Trott Oct 5, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is it cool to change the CHANGELOG after the fact like this for what amounts to (at worst) a typo? I personally think it's totally fine but uh...anyone have a problem with it?

MJefferson Oct 6, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It's unnecessary but harmless, in my opinion. It's in accord with the idea of standardizing the references - the more people see "userland" instead of "user-land" the more it catches on.

Trott commented Oct 5, 2015

Copy link
Copy Markdown
Member

Hmmm...guess there's not that many instances to change now that I see that a handful of the files are in deps. If you can undo the changes to the files in deps, I think it's good to go.

Trott added the doc Issues and PRs related to the documentations. label Oct 5, 2015

MJefferson commented Oct 6, 2015

Copy link
Copy Markdown
Contributor Author

Yeah, changing dependency files doesn't make sense. I've undone those modifications.

Trott commented Oct 6, 2015

Copy link
Copy Markdown
Member

LGTM.

Trott commented Oct 6, 2015

Copy link
Copy Markdown
Member

@MJefferson Thanks for the contribution!

If you can squash the two commits into one commit, that would be great. (And if not, no worries, I or someone else will do it when the change is landed.)

If you squash the commit, it would be great if you could also change the commit message to match the guideline in the CONTIRBUTING doc. (And again, if not, I or someone else will just do it for when the change is landed.) Since it may not be clear in this case, I would use doc as the subsystem. So the first line of the commit message might look something like this: doc: standardize references to userland

MJefferson force-pushed the standardize-userland branch from 33904d0 to 70a00e1 Compare October 7, 2015 00:13

MJefferson commented Oct 7, 2015

Copy link
Copy Markdown
Contributor Author

Done. My pleasure @Trott. : )

Trott commented Oct 7, 2015

Copy link
Copy Markdown
Member

Landed in f5a3f44. Thanks for the patch!

Trott closed this Oct 7, 2015
Trott pushed a commit that referenced this pull request Oct 7, 2015
doc: standardize references to userland
f5a3f44 
Change occurrences of "user-land" to "userland".

PR-URL: #3192
Fixes: #3189
Reviewed-By: Rich Trott <rtrott@gmail.com>
jasnell mentioned this pull request Oct 8, 2015
Closed
29 tasks
jasnell pushed a commit that referenced this pull request Oct 8, 2015
doc: standardize references to userland
d439961 
Change occurrences of "user-land" to "userland".

PR-URL: #3192
Fixes: #3189
Reviewed-By: Rich Trott <rtrott@gmail.com>
jasnell mentioned this pull request Oct 8, 2015
Closed
This was referenced Nov 30, 2023
Open
Open
This was referenced Nov 30, 2023
Open
Open
This was referenced Nov 30, 2023
Open
Open
This was referenced Dec 1, 2023
Open
Open
leonardoadame mentioned this pull request Dec 1, 2023
Open
This was referenced Dec 1, 2023
Open
Open
Open
This was referenced Dec 1, 2023
Open
Open
Open
This was referenced Dec 1, 2023
Open
Open
This was referenced Dec 2, 2023
Open
Open
Open
Open
Open
leonardoadame mentioned this pull request Dec 2, 2023
Open
This was referenced Dec 2, 2023
Open
Open
Open
Open
Open
This was referenced Dec 2, 2023
Open
Open
Open
aliscco mentioned this pull request Dec 2, 2023
Open
leonardoadame mentioned this pull request Dec 2, 2023
Open
This was referenced Dec 2, 2023
Open
Open
leonardoadame mentioned this pull request Dec 2, 2023
Open
aliscco mentioned this pull request Dec 2, 2023
Open
This was referenced Dec 3, 2023
Open
Open
aliscco mentioned this pull request Dec 3, 2023
Open
This was referenced Dec 4, 2023
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL