FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: mark empty udp tests flaky on OS X by sam-github · Pull Request #31936 · nodejs/node · GitHub

/ node Public

test: mark empty udp tests flaky on OS X - #31936

Closed
sam-github wants to merge 1 commit into
nodejs:masterfrom
sam-github:catalina-udp-flakes
ConversationCommits (1)ChecksFiles changed
Closed

test: mark empty udp tests flaky on OS X#31936
sam-github wants to merge 1 commit into
nodejs:masterfrom
sam-github:catalina-udp-flakes

Conversation

sam-github commented Feb 24, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X.

Refs: #30030
Refs: nodejs/build#2189 (comment)

Note: CI doesn't test on Catalina, yet (though I assume nodejs developers do). Test failures will indirectly block fixing of #29216, which requires running notarization on Catalina, which requires tests passing on Catalina.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

test: mark empty udp tests flaky on OS X
e8667bb 
They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X.

Refs: nodejs#30030
Refs: nodejs/build#2189 (comment)
nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 24, 2020
sam-github mentioned this pull request Feb 24, 2020
Merged
sam-github added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Feb 24, 2020

sam-github commented Feb 24, 2020

Copy link
Copy Markdown
Contributor Author

I don't have access to a machine I can repro this on, but I asked @AshCripps to try it (nodejs/build#2189 (comment)). @lpinca , perhaps you can review, too?

sam-github requested a review from lpinca February 24, 2020 18:39

lpinca commented Feb 24, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

I've run make -j8 test with the patch applied but the process still exits with 2 not sure if expected. All the tested listed here timeout as expected.

AshCripps approved these changes Feb 25, 2020
View reviewed changes

AshCripps left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Works for me. @lpinca you have to run the tests manually using the python script to skip flaky-tests like the ci does:

bash-3.2$ tools/test.py --flaky-tests=skip
[07:30|% 100|+ 2790|-   0]: Done
bash-3.2$

lpinca commented Feb 25, 2020

Copy link
Copy Markdown
Member

Oh, I forgot to use the --flaky-tests flag.

nodejs-github-bot commented Feb 25, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29350/

sam-github commented Feb 25, 2020

Copy link
Copy Markdown
Contributor Author

@AshCripps would it be helpful to get this fast-tracked? I kicked of a full CI on it, but it still needs 25 hours, but we can fast-track given its triviality and impact on CI stability if its blocking bringing the OS X 10.15/Catalina machines into CI.

AshCripps commented Feb 25, 2020

Copy link
Copy Markdown
Member

@sam-github Fast track would be useful, pretty sure every release line will fail these tests when 10.15 is added to CI

nodejs-github-bot commented Feb 25, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29351/

sam-github commented Feb 25, 2020

Copy link
Copy Markdown
Contributor Author

@nodejs/build @nodejs/testing Can we fast-track marking these tests flaky?

sam-github added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 25, 2020

sam-github commented Feb 25, 2020

Copy link
Copy Markdown
Contributor Author

Btw, the build status reported is incorrect - PR passed on everything but arm, as would be expected. I kicked a resume on the PR, though.

nodejs-github-bot commented Feb 26, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29367/

sam-github commented Feb 26, 2020

Copy link
Copy Markdown
Contributor Author

Landed in 24a4f76

sam-github closed this Feb 26, 2020
sam-github added a commit that referenced this pull request Feb 26, 2020
test: mark empty udp tests flaky on OS X
24a4f76 
They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X.

Refs: #30030
Refs: nodejs/build#2189 (comment)

PR-URL: #31936
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
BethGriggs pushed a commit that referenced this pull request Feb 27, 2020
test: mark empty udp tests flaky on OS X
9bd1317 
They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X.

Refs: #30030
Refs: nodejs/build#2189 (comment)

PR-URL: #31936
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
codebytere pushed a commit that referenced this pull request Feb 27, 2020
test: mark empty udp tests flaky on OS X
f89fb27 
They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X.

Refs: #30030
Refs: nodejs/build#2189 (comment)

PR-URL: #31936
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
codebytere mentioned this pull request Feb 29, 2020
Merged
sam-github deleted the catalina-udp-flakes branch March 6, 2020 19:04
richardlau mentioned this pull request Mar 7, 2020
Closed
4 tasks
puzpuzpuz pushed a commit to puzpuzpuz/node that referenced this pull request Mar 8, 2020
test: mark empty udp tests flaky on OS X
0b5fda0 
They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X.

Refs: nodejs#30030
Refs: nodejs/build#2189 (comment)

PR-URL: nodejs#31936
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
puzpuzpuz mentioned this pull request Mar 8, 2020
Closed
3 tasks
BethGriggs mentioned this pull request Mar 12, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
test: mark empty udp tests flaky on OS X
5a537ba 
They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X.

Refs: #30030
Refs: nodejs/build#2189 (comment)

PR-URL: #31936
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

PR-URL: #32146
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
BethGriggs BethGriggs approved these changes
+2 more reviewers
rvagg rvagg approved these changes
AshCripps AshCripps approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL