FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: apply linting to custom rules code by Trott · Pull Request #3195 · nodejs/node · GitHub

/ node Public

tools: apply linting to custom rules code - #3195

Closed
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:eslint-rules
ConversationCommits (2)ChecksFiles changed
Closed

tools: apply linting to custom rules code#3195
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:eslint-rules

Conversation

Trott commented Oct 5, 2015

Copy link
Copy Markdown
Member

Node.js project-specific estlint rules should maintain the style of the rest of the project JS code base.

Ref: #3157

Trott added the tools Issues and PRs related to the tools directory. label Oct 5, 2015

Trott commented Oct 5, 2015

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/422/

bnoordhuis reviewed Oct 5, 2015
View reviewed changes
Comment thread Makefile Outdated

bnoordhuis Oct 5, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe put a break before --rulesdir.

Trott Oct 6, 2015

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sure, line break added!

bnoordhuis commented Oct 5, 2015

Copy link
Copy Markdown
Member

LGTM

Trott mentioned this pull request Oct 5, 2015
Closed

Trott commented Oct 6, 2015

Copy link
Copy Markdown
Member Author

New CI with line break added: https://ci.nodejs.org/job/node-test-pull-request/425/

thefourtheye commented Oct 6, 2015

Copy link
Copy Markdown
Contributor

LGTM

bnoordhuis commented Oct 6, 2015

Copy link
Copy Markdown
Member

Still LGTM BTW.

silverwind commented Oct 6, 2015

Copy link
Copy Markdown
Contributor

Whoops, my bad on that style in that rule file. LGTM

Trott commented Oct 6, 2015

Copy link
Copy Markdown
Member Author

Landed in dbce29a

Trott closed this Oct 6, 2015
Trott added a commit that referenced this pull request Oct 6, 2015
tools: apply linting to custom rules code
dbce29a 
Apply our eslint rules to the code for our custom eslint rules.

Eslint Inception! Maybe. I never saw that movie...

PR-URL: #3195
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Reiss <me@silverwind.io>
jasnell mentioned this pull request Oct 8, 2015
Closed
29 tasks
Trott added a commit that referenced this pull request Oct 8, 2015
tools: apply linting to custom rules code
5d9f83f 
Apply our eslint rules to the code for our custom eslint rules.

Eslint Inception! Maybe. I never saw that movie...

PR-URL: #3195
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Reiss <me@silverwind.io>
jasnell mentioned this pull request Oct 8, 2015
Closed
Trott deleted the eslint-rules branch January 13, 2022 22:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL