FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add method links in dns.markdown by a0viedo · Pull Request #3196 · nodejs/node · GitHub

/ node Public

doc: add method links in dns.markdown - #3196

Closed
a0viedo wants to merge 1 commit into
nodejs:masterfrom
a0viedo:patch-2
Closed

doc: add method links in dns.markdown#3196
a0viedo wants to merge 1 commit into
nodejs:masterfrom
a0viedo:patch-2

Conversation

a0viedo commented Oct 6, 2015

Copy link
Copy Markdown
Member

Added links to referenced methods and added parenthesis to follow consistency.

Comment thread doc/api/dns.markdown Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

When you are using the same thing again and again you can add the reference at the bottom.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@thefourtheye oh yeah I forgot about that, thanks.

Added links to referenced methods.
mscdex added doc Issues and PRs related to the documentations. dns Issues and PRs related to the dns subsystem. labels Oct 6, 2015

Copy link
Copy Markdown
Contributor

LGTM

silverwind pushed a commit that referenced this pull request Oct 9, 2015
Added links to referenced methods.

PR-URL: #3196
Reviewed-By: Roman Reiss <me@silverwind.io>>

Copy link
Copy Markdown
Contributor

Thanks! Landed in 70c78c9.

silverwind closed this Oct 9, 2015
a0viedo deleted the patch-2 branch October 9, 2015 19:05
jasnell pushed a commit that referenced this pull request Oct 10, 2015
Added links to referenced methods.

PR-URL: #3196
Reviewed-By: Roman Reiss <me@silverwind.io>>

jasnell commented Oct 10, 2015

Copy link
Copy Markdown
Member

landed in v4.x in 6dd3476

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL