src: revamp internal field count tracking - #31960
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
2 tasks
addaleax
reviewed
Feb 26, 2020
Comment thread
src/async_wrap.cc
Outdated
Comment thread
src/base_object-inl.h
Outdated
Comment thread
src/cares_wrap.cc
Outdated
jasnell
force-pushed
the
revamp-internal-field-count-tracking
branch
from
39f07a2 to
ec851dc
Compare
February 26, 2020 03:29
addaleax
approved these changes
Feb 26, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
bnoordhuis
reviewed
Feb 26, 2020
bnoordhuis
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks, this is already much better than the current state of things and looks like it already exposes a few infidelities and at least one outright bug.
Sorry, something went wrong.
Comment thread
src/async_wrap.cc
Outdated
Comment thread
src/base_object.h
Outdated
Comment thread
src/node_object_wrap.h
Outdated
Comment thread
src/stream_base.h
Outdated
Comment thread
src/stream_base.h
Outdated
Comment thread
src/stream_wrap.cc
Outdated
addaleax
requested changes
Feb 26, 2020
Comment thread
src/async_wrap.cc
Outdated
2 tasks
addaleax
approved these changes
Feb 26, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
fhinkel
approved these changes
Feb 27, 2020
bnoordhuis
approved these changes
Feb 28, 2020
bnoordhuis
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks, LGTM with suggestions.
Sorry, something went wrong.
Comment thread
src/stream_base-inl.h
Outdated
Comment thread
src/stream_base.h
Outdated
Comment thread
src/stream_base.h
Outdated
mcollina
approved these changes
Feb 28, 2020
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Change suggested by bnoordhuis. Improve handing of internal field counting by using enums. Helps protect against future possible breakage if field indexes are ever changed or added to. Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
revamp-internal-field-count-tracking
branch
from
aa26581 to
9c6e9cd
Compare
February 29, 2020 01:46
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
added a commit
that referenced
this pull request
Mar 2, 2020
Change suggested by bnoordhuis. Improve handing of internal field counting by using enums. Helps protect against future possible breakage if field indexes are ever changed or added to. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #31960 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Copy link
Copy Markdown
Member
Author
|
Landed in 0fac393 |
Sorry, something went wrong.
MylesBorins
pushed a commit
that referenced
this pull request
Mar 4, 2020
Change suggested by bnoordhuis. Improve handing of internal field counting by using enums. Helps protect against future possible breakage if field indexes are ever changed or added to. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #31960 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
Copy link
Copy Markdown
Member
|
Depends at least on #31569 to land on v12.x |
Sorry, something went wrong.
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Change suggested by bnoordhuis. Improve handing of internal field counting by using enums. Helps protect against future possible breakage if field indexes are ever changed or added to. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#31960 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
Change suggested by bnoordhuis. Improve handing of internal field counting by using enums. Helps protect against future possible breakage if field indexes are ever changed or added to. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #31960 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved handling of internal field counts.
In a separate PR, it would likely be good to switch to use of utility functions that include DCHECKs for the InternalFieldCount().
/cc @bnoordhuis @addaleax
Checklist