FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix flaky test-dns-any.js by Trott · Pull Request #32017 · nodejs/node · GitHub

/ node Public

test: fix flaky test-dns-any.js - #32017

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:fix-dns
Mar 2, 2020
ConversationCommits (1)ChecksFiles changed
Merged

test: fix flaky test-dns-any.js#32017
Trott merged 1 commit into
nodejs:masterfrom
Trott:fix-dns

Conversation

Trott commented Feb 29, 2020

Copy link
Copy Markdown
Member

Remove google.com from domains tested with ANY queries.

Fixes: #31721

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 29, 2020

Trott commented Feb 29, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Custom internet CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12505/ ✅

Trott commented Feb 29, 2020

Copy link
Copy Markdown
Member Author

Custom internet CI against master to make sure this test is still failing there without this change: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12506/

Trott commented Feb 29, 2020

Copy link
Copy Markdown
Member Author

Custom internet CI against master to make sure this test is still failing there without this change: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12506/

That one had the test here passing, but it was on a different host than the recent failures. Here's a run that (like the one that passed with the changes in this PR) is on the host that has been failing this test recently: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12507/

Trott commented Feb 29, 2020

Copy link
Copy Markdown
Member Author

That one had the test here passing, but it was on a different host than the recent failures. Here's a run that (like the one that passed with the changes in this PR) is on the host that has been failing this test recently: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12507/

And that one failed! So it looks like this makes the test pass. Fast-track, anyone? Please 👍 here. This will unbreak nightly CI.

Trott added dns Issues and PRs related to the dns subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Feb 29, 2020
test: fix flaky test-dns-any.js
fb74e98 
Remove google.com from domains tested with ANY queries.

Fixes: nodejs#31721

PR-URL: nodejs#32017
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott commented Mar 2, 2020

Copy link
Copy Markdown
Member Author

Landed in fb74e98

Trott merged commit fb74e98 into nodejs:master Mar 2, 2020
Trott deleted the fix-dns branch March 2, 2020 15:03
codebytere mentioned this pull request Mar 3, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 3, 2020
test: fix flaky test-dns-any.js
49864d1 
Remove google.com from domains tested with ANY queries.

Fixes: #31721

PR-URL: #32017
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 15, 2020
test: fix flaky test-dns-any.js
563a21a 
Remove google.com from domains tested with ANY queries.

Fixes: #31721

PR-URL: #32017
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
test: fix flaky test-dns-any.js
2d3926c 
Remove google.com from domains tested with ANY queries.

Fixes: #31721

PR-URL: #32017
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
test: fix flaky test-dns-any.js
3574116 
Remove google.com from domains tested with ANY queries.

Fixes: #31721

PR-URL: #32017
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
lpinca lpinca approved these changes
tniessen tniessen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. dns Issues and PRs related to the dns subsystem. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

investigate unreliability in test-dns-any

5 participants

Back | FazBrowse Home | New Git URL