stream: eos make const state const - #32031
Closed
ronag wants to merge 3 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ronag
requested review from
mafintosh and
mcollina
and removed request for
mafintosh
March 1, 2020 18:21
mcollina
approved these changes
Mar 1, 2020
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
CI failed, needs investigating |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Mar 1, 2020
Comment thread
lib/internal/streams/end-of-stream.js
Outdated
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
writable & readable is based on type and is not actual state, treat them as such.
Copy link
Copy Markdown
Member
Author
|
rebased to fix conflicts |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
ronag
added a commit
that referenced
this pull request
Mar 3, 2020
writable & readable is based on type and is not actual state, treat them as such. PR-URL: #32031 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Copy link
Copy Markdown
Contributor
|
This doesn't land cleanly on v13.x. If it is applicable to that release line could you please open a backporrt |
Sorry, something went wrong.
7 tasks
4 tasks
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Mar 10, 2020
writable & readable is based on type and is not actual state, treat them as such. PR-URL: nodejs#32031 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Backport-PR-URL: nodejs#32178
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writable & readable is based on type and is not actual state, treat them as such. Also fixes an invalid test.
Checklist